[E2E-Test]: add Test_EIBC_Client_NoFundForToken_EVM #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hungdinh82
force-pushed
the
hung/testEibcClientNofunforTokenEVM
branch
from
821c60a
to
55f09be
Compare
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| // testutil.AssertBalance(t, ctx, rollapp1, rollappUserAddr, rollapp1.Config().Denom, walletAmount.Sub(transferData.Amount)) | ||
|
|
||
| // wait until the packet is finalized | ||
| isFinalized, err := dymension.WaitUntilRollappHeightIsFinalized(ctx, rollapp1.GetChainID(), rollappHeight, 300) |
There was a problem hiding this comment.
We dont need wait anymore @hungdinh82
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| require.NoError(t, err) | ||
| require.True(t, isFinalized) | ||
|
|
||
| txhash, err := dymension.GetNode().FinalizePacketsUntilHeight(ctx, dymensionUserAddr, rollapp1.GetChainID(), fmt.Sprint(rollappHeight)) |
There was a problem hiding this comment.
not need to finalize packets too
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| require.NoError(t, err) | ||
|
|
||
| // Minus 0.1% of transfer amount for bridge fee | ||
| testutil.AssertBalance(t, ctx, dymension, dymensionUserAddr2, rollappIBCDenom, transferData.Amount.Sub(bridgingFee).Sub(eibcFee)) |
There was a problem hiding this comment.
not sub eibcFee because order didn't fulfilled
|
Close #430 |
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| err = testutil.WaitForBlocks(ctx, 10, dymension, rollapp1) | ||
| require.NoError(t, err) | ||
|
|
||
| err = testutil.WaitForBlocks(ctx, 10, dymension, rollapp1) |
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| err = testutil.WaitForBlocks(ctx, 10, dymension, rollapp1) | ||
| require.NoError(t, err) | ||
|
|
||
| rollappHeight, err := rollapp1.GetNode().Height(ctx) |
anhductn2001
reviewed
Oct 7, 2024
tests/eibc_client_test.go
Outdated
| rollappHeight, err := rollapp1.GetNode().Height(ctx) | ||
| require.NoError(t, err) | ||
|
|
||
| err = testutil.WaitForBlocks(ctx, 5, dymension, rollapp1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.