Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Fee Rule Functionality #36

Closed
yishay-dym opened this issue Aug 25, 2024 · 0 comments · Fixed by #38
Closed

Add Fee Rule Functionality #36

yishay-dym opened this issue Aug 25, 2024 · 0 comments · Fixed by #38
Assignees

Comments

@yishay-dym
Copy link

yishay-dym commented Aug 25, 2024

We want to enhance the eIBC bot with a new feature that allows the bot to determine whether to fulfill an order based on fee rules. These rules will be configurable and will be applied on a per-rollup (chain ID) and per-asset (denom) basis.

e.g

roller eibc min-fee-chain <%> < chain-id >
roller eibc min-fee-asset <%> < denom >

(this is just an example ^ please choose the best syntax you can think of)

Chain ID-based Fee Rules:

Add a configuration option to set a minimum fee percentage for each rollup (identified by its chain ID).
The bot should check the provided fee against this rule before fulfilling an order.

Asset-based Fee Rules:

Add a configuration option to set a minimum fee percentage for each asset (identified by its denom).
The bot should also check the provided fee against this rule before fulfilling an order.

Rule Application:

The bot should apply both the chain ID-based and asset-based fee rules.
The bot should only fulfill an order if the fee meets or exceeds both the chain ID-specific and asset-specific minimum fee percentages.

Example Configuration:

Chain ID: chain-1, Min Fee: 0.5%
Asset Denom: asset-xyz, Min Fee: 0.2%
In this case, for an order to be fulfilled on chain-1 involving asset-xyz, the fee must be at least 0.5%.

Acceptance Criteria:

The bot should correctly evaluate fee rules for both chain IDs and asset denoms.
Orders should only be fulfilled if the fees meet the specified minimums.
The configuration should be easily adjustable for different chain IDs and asset denoms.

@omritoptix omritoptix changed the title Add Fee Rule Functionality to eIBC Bot Add Fee Rule Functionality Aug 25, 2024
@omritoptix omritoptix linked a pull request Sep 17, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants