Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: fee rule functionality #38

Merged
merged 1 commit into from
Sep 17, 2024
Merged

feat: fee rule functionality #38

merged 1 commit into from
Sep 17, 2024

Conversation

zale144
Copy link
Collaborator

@zale144 zale144 commented Aug 29, 2024

This section will be added to the config file:

fulfill_criteria:
    min_fee_percentage:
        chain:
            rollapp_1234-1: 0.12
            rollapp_1234-2: 0.14
        asset:
            adym: 0.13
            ibc/5a26c8dc8da66f4dd94326e67f94510188f5f7afe2db3933a0c823670e56eabf: 0.15
            ibc/9A1EACD53A6A197ADC81DF9A49F0C4A26F7FF685ACF415EE726D7D59796E71A7: 0.14

The chains and assets mapped there will also act as a whitelist for order rollappIDs and denoms.

Closes #34 and #37

@zale144 zale144 self-assigned this Aug 29, 2024
@artemijspavlovs
Copy link
Contributor

artemijspavlovs commented Aug 30, 2024 •
edited
Loading

percentage of what are these exactly?

upd:

percentage is "what percentage of the total order amount the fee is"

@omritoptix omritoptix linked an issue Sep 17, 2024 that may be closed by this pull request
Add Fee Rule Functionality #36
Closed
@omritoptix omritoptix merged commit 3564ddf into zale144/17-add-expected-fee-to-order-fulfillment Sep 17, 2024
1 check passed
zale144 added a commit that referenced this pull request Sep 17, 2024
@zale144
add expected fee to order fulfillment (#40)
cd13d75 
* Add expected fee to order fulfillment

* Add expected fee to order fulfillment

* Fix event subscriptions: order-created, order-finalized

* Fix linter issue

* Fix linter issue

* Fix more linter issues

* feat: fee rule functionality (#38)

Fee rule functionality, refactor

* Fix fee parsing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemijspavlovs artemijspavlovs artemijspavlovs approved these changes

Assignees

@zale144 zale144

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Fee Rule Functionality
3 participants
@zale144 @artemijspavlovs @omritoptix