imp(evm): restrict VFBC deployment on top of Module Account or EOA #16
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior is deploy VFBC no matter account is existing or not, no matter the type of the account is. The only restriction is the existing account must Not be a contract account.
Even tho the chance of override an existing Module Account or EOA is almost equals to brute forcing private key of a wallet.
This PR can be ignored without any consequence.
Brief of code change:
Plus the existing one (restrict deploy VFBC if existing account is a VFBC contract), we have 3.
Added test-cases:
In case VFBC was stopped deploying due to the restriction defined above. We just need to shift sequence number of the deployment module account by one and everything will be fine.