chore: update rollapp registration script to follow new flow #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artemijspavlovs
force-pushed
the
artemijspavlovs/new-rollapp-registration-flow
branch
from
fdc092c
to
7f95451
Compare
danwt
previously approved these changes
Aug 1, 2024
Comment on lines
55
to
95
| { | ||
| "moniker": "Sample Moniker", | ||
| "details": "Some details about the sequencer", | ||
| "p2p_seeds": [ | ||
| "seed1.example.com:26656", | ||
| "seed2.example.com:26656" | ||
| ], | ||
| "rpcs": [ | ||
| "http://rpc1.example.com:26657", | ||
| "http://rpc2.example.com:26657" | ||
| ], | ||
| "evm_rpcs": [ | ||
| "http://evm-rpc1.example.com:8545", | ||
| "http://evm-rpc2.example.com:8545" | ||
| ], | ||
| "rest_api_url": "http://restapi.example.com", | ||
| "explorer_url": "http://explorer.example.com", | ||
| "genesis_urls": [ | ||
| "http://genesis1.example.com", | ||
| "http://genesis2.example.com" | ||
| ], | ||
| "contact_details": { | ||
| "website": "http://website.example.com", | ||
| "telegram": "https://t.me/example", | ||
| "x": "https://twitter.com/example" | ||
| }, | ||
| "extra_data": "RXh0cmEgZGF0YSBzYW1wbGU=", // Base64 encoded data | ||
| "snapshots": [ | ||
| { | ||
| "snapshot_url": "http://snapshot1.example.com", | ||
| "height": 123456, | ||
| "checksum": "d41d8cd98f00b204e9800998ecf8427e" | ||
| }, | ||
| { | ||
| "snapshot_url": "http://snapshot2.example.com", | ||
| "height": 789012, | ||
| "checksum": "e2fc714c4727ee9395f324cd2e7f331f" | ||
| } | ||
| ], | ||
| "gas_price": "1000000" | ||
| } |
There was a problem hiding this comment.
maybe it's better to store these in a file
There was a problem hiding this comment.
yeah, I though the same but that the user needs to run the script from a specific location and the json file needs to be at an expected location all the time... this way user can run the scripts from wherever he wants, that's why it's inline
since the sequencer metadata is optional, the dummy file will just be an empty json object, that's shorter
danwt
approved these changes
Aug 8, 2024
mtsitrin
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #XXX
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleasedsection inCHANGELOG.mdgodoccommentsSDK Checklist
maptime.Now()sendCoinand notSendCoinsFull security checklist here
----;
For Reviewer:
---;
After reviewer approval: