Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sequencer address checks upon init #1100

Merged
merged 9 commits into from
Nov 8, 2024
Merged

feat: add sequencer address checks upon init #1100

merged 9 commits into from
Nov 8, 2024

Conversation

artemijspavlovs
Copy link
Collaborator

PR Standards

Opening a pull request should be able to meet the following requirements

For Author:

  • Targeted PR against correct branch
  • Included the correct type prefix in the PR title
  • Linked to Github issue with discussion and accepted design
  • Targets only one github issue
  • Wrote unit and integration tests
  • All CI checks have passed
  • Added relevant godoc comments

For Reviewer:

  • Confirmed the correct type prefix in the PR title
  • Reviewers assigned
  • Confirmed all author checklist items have been addressed

After reviewer approval:

  • In case PR targets main branch, PR should be squashed and merged.
  • In case PR targets a release branch, PR should be rebased.

@artemijspavlovs artemijspavlovs requested a review from a team as a code owner November 8, 2024 08:01
@artemijspavlovs artemijspavlovs merged commit 0d6693a into main Nov 8, 2024
2 checks passed
@artemijspavlovs artemijspavlovs deleted the artemijspavlovs/add-sequencer-address-checks branch November 8, 2024 08:28
@github-actions github-actions bot mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@artemijspavlovs