Empty tags fixing

dynatrace-oss · Jan 7, 2021 · 8fdcbe3 · 8fdcbe3
1 parent 92943b3
commit 8fdcbe3
Show file tree

Hide file tree

Showing 3 changed files with 60 additions and 56 deletions.
diff --git a/dist/index.js b/dist/index.js
diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/dynatrace.ts b/src/dynatrace.ts
@@ -61,16 +61,19 @@ export async function sendMetrics(
 
   for (const m of metrics) {
     lines = lines.concat(safeMetricKey(m.metric))
-    for (const [key, value] of Object.entries(m.dimensions)) {
-      if (value && value.length > 0) {
-        lines = lines
-          .concat(',')
-          .concat(safeDimKey(key))
-          .concat('="')
-          .concat(safeDimValue(value))
-          .concat('"')
+    if(m.dimensions) {
+      for (const [key, value] of Object.entries(m.dimensions)) {
+        if (value && value.length > 0) {
+          lines = lines
+            .concat(',')
+            .concat(safeDimKey(key))
+            .concat('="')
+            .concat(safeDimValue(value))
+            .concat('"')
+        }
       }
     }
+
     lines = lines.concat(' ').concat(m.value).concat('\n')
   }
   core.info(lines)
@@ -97,7 +100,7 @@ export async function sendEvents(
   for (const e of events) {
     const tagAttachRules : TagAttachRule[] = [];
     // extract tagging rules
-    if(e.hasOwnProperty('tags')) {
+    if(e.tags) {
       for (const t of e.tags) {
         const arr = t.split(':')
         if (arr.length === 2) {