Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#784 Nightly release and release without mpi #801

Merged
merged 2 commits into from
Dec 4, 2024
Merged

#784 Nightly release and release without mpi #801

merged 2 commits into from
Dec 4, 2024

Conversation

barondim
Copy link
Collaborator

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non regression tests were added (update of inputs, outputs, SA, algos)
  • main documentation was updated (update of input/output file)
  • the corresponding milestone was added in the ticket and in this PR

@barondim barondim added this to the v1.7.0 milestone Oct 31, 2024
@barondim barondim changed the title #784 Nightly release and release without mpi (nightly-release.yml only) #784 Nightly release and release without mpi Oct 31, 2024
@barondim barondim linked an issue Oct 31, 2024 that may be closed by this pull request
Nightly release and release without mpi #784
Closed
@barondim barondim force-pushed the 784_Nightly_release_and_release_without_mpi branch 2 times, most recently from 8c73591 to 98bca58 Compare November 5, 2024 17:55
@gautierbureau
Copy link
Member

we don't need to do it for Linux release

@barondim barondim force-pushed the 784_Nightly_release_and_release_without_mpi branch from 98bca58 to ccc5e4b Compare November 6, 2024 10:00
@barondim barondim force-pushed the 784_Nightly_release_and_release_without_mpi branch 2 times, most recently from 79eec1c to 095a3ba Compare November 22, 2024 13:25
@barondim barondim marked this pull request as ready for review November 22, 2024 17:36
gautierbureau
gautierbureau requested changes Dec 2, 2024
View reviewed changes
sources/main.cpp Outdated Show resolved Hide resolved
@barondim
#784 Nightly release and release without mpi
fb31584 
Signed-off-by: Dimitri Baron <[email protected]>
@barondim
#784 PR remark
e038521 
Signed-off-by: Dimitri Baron <[email protected]>
@barondim barondim force-pushed the 784_Nightly_release_and_release_without_mpi branch from b40301b to e038521 Compare December 2, 2024 10:28
This was referenced Dec 2, 2024
Closed
Merged
@barondim
Copy link
Collaborator Author

barondim commented Dec 2, 2024

@gautierbureau gautierbureau merged commit 5593480 into master Dec 4, 2024
5 checks passed
@gautierbureau gautierbureau deleted the 784_Nightly_release_and_release_without_mpi branch December 4, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gautierbureau gautierbureau gautierbureau approved these changes

@rosiereflo rosiereflo Awaiting requested review from rosiereflo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Nightly release and release without mpi
2 participants
@barondim @gautierbureau