Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#833 update following introduction of a deadband in Secondary Voltage… #835

Merged
merged 1 commit into from
Jan 29, 2025
Merged

#833 update following introduction of a deadband in Secondary Voltage… #835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion sources/Outputs/src/ParDynModel.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ std::shared_ptr<parameters::ParametersSet> ParDynModel::writeSVCParameterSet(con

std::unordered_map<std::string, double> genInitialParamToValues;
for (const auto &param : set.doubleParameters) {
if (param.name == "secondaryVoltageControl_Alpha" || param.name == "secondaryVoltageControl_Beta") {
if (param.name == "secondaryVoltageControl_Alpha" || param.name == "secondaryVoltageControl_Beta" || param.name == "secondaryVoltageControl_UDeadBandPu") {
new_set->addParameter(helper::buildParameter(param.name, param.value));
} else if (param.name.find("secondaryVoltageControl_Qr_") != std::string::npos) {
genInitialParamToValues[param.name] = param.value;
Expand Down
1 change: 1 addition & 0 deletions tests/main/reference/hvdc_svc/TestIIDM_hvdc_svc.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="300"/>
<par name="secondaryVoltageControl_Qr_2_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_SNom_0_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_XTfoPu_0_" type="DOUBLE" value="0.1426"/>
<par name="secondaryVoltageControl_XTfoPu_1_" type="DOUBLE" value="0.1426"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
Expand Down
154 changes: 77 additions & 77 deletions tests/main/reference/hvdc_svc/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/hvdc_svc_side2/TestIIDM_hvdc_svc_side2.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,7 @@
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="300"/>
<par name="secondaryVoltageControl_Qr_2_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_SNom_0_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_XTfoPu_0_" type="DOUBLE" value="0.1426"/>
<par name="secondaryVoltageControl_XTfoPu_1_" type="DOUBLE" value="0.1426"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
Expand Down
154 changes: 77 additions & 77 deletions tests/main/reference/hvdc_svc_side2/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/launch_svc/TestIIDM_launch_svc.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@
<par name="secondaryVoltageControl_Qr_0_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="290"/>
<par name="secondaryVoltageControl_SNom_1_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
<par name="secondaryVoltageControl_limUQDown0_1_" type="BOOL" value="false"/>
<par name="secondaryVoltageControl_limUQUp0_0_" type="BOOL" value="false"/>
Expand Down
90 changes: 45 additions & 45 deletions tests/main/reference/launch_svc/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/launch_svc_infinite/TestIIDM_launch_svc_infinite.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,7 @@
<par name="secondaryVoltageControl_Qr_0_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="290"/>
<par name="secondaryVoltageControl_SNom_1_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
<par name="secondaryVoltageControl_limUQDown0_1_" type="BOOL" value="false"/>
<par name="secondaryVoltageControl_limUQUp0_0_" type="BOOL" value="false"/>
Expand Down
90 changes: 45 additions & 45 deletions tests/main/reference/launch_svc_infinite/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/launch_svc_network/TestIIDM_launch_svc_network.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@
<par name="secondaryVoltageControl_Participate0_0_" type="BOOL" value="true"/>
<par name="secondaryVoltageControl_Qr_0_" type="DOUBLE" value="290"/>
<par name="secondaryVoltageControl_SNom_0_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
<par name="secondaryVoltageControl_limUQUp0_0_" type="BOOL" value="false"/>
<reference type="DOUBLE" name="secondaryVoltageControl_P0Pu_0_" origData="IIDM" origName="p_pu" componentId="_GEN____2_SM"/>
Expand Down
90 changes: 45 additions & 45 deletions tests/main/reference/launch_svc_network/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/launch_svc_tfo/TestIIDM_launch_svc_tfo.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,7 @@
<par name="secondaryVoltageControl_Qr_0_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="290"/>
<par name="secondaryVoltageControl_SNom_1_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_XTfoPu_0_" type="DOUBLE" value="0.12280000000000001"/>
<par name="secondaryVoltageControl_XTfoPu_1_" type="DOUBLE" value="0.12280000000000001"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
Expand Down
90 changes: 45 additions & 45 deletions tests/main/reference/launch_svc_tfo/outputIIDM.xml
View file
Open in desktop

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions tests/main/reference/launch_svc_tfo_infinite/TestIIDM_launch_svc_tfo_infinite.par
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
<par name="secondaryVoltageControl_Qr_0_" type="DOUBLE" value="280"/>
<par name="secondaryVoltageControl_Qr_1_" type="DOUBLE" value="290"/>
<par name="secondaryVoltageControl_SNom_1_" type="DOUBLE" value="2401.27"/>
<par name="secondaryVoltageControl_UDeadBandPu" type="DOUBLE" value="0.0001"/>
<par name="secondaryVoltageControl_XTfoPu_0_" type="DOUBLE" value="0.12280000000000001"/>
<par name="secondaryVoltageControl_XTfoPu_1_" type="DOUBLE" value="0.12280000000000001"/>
<par name="secondaryVoltageControl_limUQDown0_0_" type="BOOL" value="false"/>
Expand Down
Loading
Loading