Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#413 Code smells fix #439

Merged
merged 1 commit into from
Nov 27, 2024
Merged

#413 Code smells fix #439

merged 1 commit into from
Nov 27, 2024

Conversation

barondim
Copy link
Collaborator

Checklist before requesting a review

use '[x]' to check the checkboxes, or submit the PR and then click the checkboxes

  • unit tests and non regression tests were added (update of algorithms)
  • main documentation was updated (update of input/output file, update of algorithms)
  • the corresponding milestone was added in the ticket and in this PR
  • if this PR modifies a dictionary: the corresponding french dictionary was updated

@barondim
#413 Code smells fix
b0e579e 
Signed-off-by: Dimitri Baron <[email protected]>
@barondim barondim added this to the v1.7.0 milestone Nov 27, 2024
@barondim barondim linked an issue Nov 27, 2024 that may be closed by this pull request
Code smells fix #413
Closed
@rosiereflo rosiereflo merged commit f2baec6 into master Nov 27, 2024
5 checks passed
@rosiereflo rosiereflo deleted the 413_Code_smells_fix_3 branch November 27, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosiereflo rosiereflo rosiereflo approved these changes

@gautierbureau gautierbureau Awaiting requested review from gautierbureau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Code smells fix
2 participants
@barondim @rosiereflo