Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: 👷 align releases and remove tag in case of failure #665

Merged
merged 6 commits into from
Aug 8, 2023
Merged

ci: 👷 align releases and remove tag in case of failure #665

merged 6 commits into from
Aug 8, 2023

Conversation

matteo-cristino
Copy link
Collaborator

No description provided.

@matteo-cristino matteo-cristino added SKIP_JS Add this label to PR for skip JS checks in CI SKIP_RUST Add this label to PR for skip RUST checks in CI SKIP_PY Add this label to PR for skip PY checks in CI SKIP_GO Add this label to PR for skip GO checks in CI labels Jun 5, 2023
@matteo-cristino matteo-cristino removed the SKIP_JS Add this label to PR for skip JS checks in CI label Jul 4, 2023
@matteo-cristino matteo-cristino changed the title ci: 👷 align npm, pypi and binary releases ci: 👷 align releases and remove tag in case of failure Jul 4, 2023
@matteo-cristino
Copy link
Collaborator Author

In this PR I have aligned PyPI, npm and github releases. In this way if one build fail no release will be made in any of them. Moreover, to keep their version aligned with the github version, in case of failure of one of the builds no release will be made and the tag released on github will be eliminated. This works also with jobs cancellation so that if a new PR is merged during the build phase the CI will be stopped and the github tag will be eliminated. This should help to keep all the version aligned.

Also the js release is build after the semantic versioning so the tag now match with the commit hash.

@andrea-dintino
Copy link
Member

@jaromil can we pretty please merge?

@jaromil jaromil merged commit cf4779e into master Aug 8, 2023
28 checks passed
@jaromil jaromil deleted the ci/releases branch August 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@puria puria puria approved these changes

Assignees
No one assigned
Labels
SKIP_GO Add this label to PR for skip GO checks in CI SKIP_PY Add this label to PR for skip PY checks in CI SKIP_RUST Add this label to PR for skip RUST checks in CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@matteo-cristino @andrea-dintino @puria @jaromil