Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keep names to naming strategy #105

Merged
merged 4 commits into from
Feb 11, 2025
Merged

Conversation

ndamania00
Copy link
Collaborator

@ndamania00 ndamania00 commented Feb 11, 2025

Addresses the thread here
This adds KEEP_NAMES as a Benchling naming strategy.

Dyno does not have this option in our Benchling Tenants which is why this wasn't included. This is a safe addition to the enum so updated.

@ndamania00 ndamania00 added type:bug Something isn't working semver:patch A backwards compatible bug fix (patch version bump) labels Feb 11, 2025
@ndamania00 ndamania00 changed the base branch from main to translation-link-bug-fix February 11, 2025 01:34
Base automatically changed from translation-link-bug-fix to main February 11, 2025 01:42
@ndamania00 ndamania00 merged commit 21632e2 into main Feb 11, 2025
2 checks passed
@ndamania00 ndamania00 deleted the add-keep-names-to-naming-strategy branch February 11, 2025 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver:patch A backwards compatible bug fix (patch version bump) type:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant