Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(crux): WS session expire cleanup #823

Merged
merged 10 commits into from
Sep 21, 2023
Merged

fix(crux): WS session expire cleanup #823

merged 10 commits into from
Sep 21, 2023

Conversation

robot9706
Copy link
Contributor

@robot9706 robot9706 commented Sep 14, 2023 •
edited
Loading

  • The WS adapter did not handle expired sessions correctly, resulting in stuck editor instances.
  • Enabled no-floating-promises lint error for crux

@robot9706 robot9706 self-assigned this Sep 14, 2023
@github-actions github-actions bot added pr:fix source:web The scope of the issue or pull request is web. lang:typescript labels Sep 14, 2023
@robot9706 robot9706 marked this pull request as ready for review September 14, 2023 12:15
@robot9706 robot9706 requested a review from a team as a code owner September 14, 2023 12:15
@robot9706 robot9706 marked this pull request as draft September 15, 2023 13:25
@robot9706 robot9706 force-pushed the fix/ws-editor-leave branch 2 times, most recently from 8a2b34a to 8d6a736 Compare September 18, 2023 13:03
@robot9706 robot9706 marked this pull request as ready for review September 18, 2023 14:02
m8vago
m8vago requested changes Sep 18, 2023
View reviewed changes
web/crux-ui/src/websockets/websocket-client.ts Outdated Show resolved Hide resolved
web/crux-ui/src/websockets/websocket-client.ts Outdated Show resolved Hide resolved
web/crux/src/websockets/dyo.ws.adapter.ts Outdated Show resolved Hide resolved
web/crux/src/websockets/route.ts Outdated Show resolved Hide resolved
polaroi8d
polaroi8d approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (informal)

@m8vago m8vago merged commit 2059ab0 into develop Sep 21, 2023
17 checks passed
@m8vago m8vago deleted the fix/ws-editor-leave branch September 21, 2023 13:37
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@robot9706 @chandhuDev
fix(crux): WS session expire cleanup (dyrector-io#823)
4cd6766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

@m8vago m8vago m8vago approved these changes

Assignees

@robot9706 robot9706

Labels
lang:typescript pr:fix severity:medium source:web The scope of the issue or pull request is web.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robot9706 @m8vago @polaroi8d