Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): add phony for k3d-rm makefile target (the only one missing) #833

Merged
merged 3 commits into from
Oct 17, 2023

Conversation

AmorfEvo
Copy link
Contributor

@AmorfEvo AmorfEvo commented Sep 27, 2023

We do not trigger our entire GitHub workflow when making certain changes, such as editing the PR title or only modifying the PR comments without any code changes.
In these cases, code linting and E2E testing would not be necessary.

  • fix(ci): add phony for k3d-rm makefile target (the only one missing)
  • feat(ci): optimize github workflow for non-code changes

@github-actions github-actions bot added pr:feat lang:makefile source:build Makefiles, Dockerfiles, etc and removed pr:feat labels Sep 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 27, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a6cff69) 26.27% compared to head (e2ac4d8) 26.30%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #833      +/-   ##
===========================================
+ Coverage    26.27%   26.30%   +0.02%     
===========================================
  Files           70       70              
  Lines         7346     7346              
===========================================
+ Hits          1930     1932       +2     
+ Misses        5265     5263       -2     
  Partials       151      151              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandor-magyar nandor-magyar self-requested a review September 27, 2023 12:18
@nandor-magyar nandor-magyar changed the title feat(ci): optimize github workflow for non-code changes fix(ci): add phony for k3d-rm makefile target (the only one missing) Oct 17, 2023
@polaroi8d polaroi8d marked this pull request as ready for review October 17, 2023 08:41
@polaroi8d polaroi8d requested a review from a team as a code owner October 17, 2023 08:41
@polaroi8d polaroi8d merged commit 6a77bd0 into develop Oct 17, 2023
26 checks passed
@polaroi8d polaroi8d deleted the feat/github-workflow-non-code-changes branch October 17, 2023 08:42
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants