Make shared lib builds work on Darwin #124
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `makefile` was assuming that the shared libarary extension would always be `.so`, which is not accurate. On Darwin in particular, the default shared library extension is `.dylib`. This commit adds proper OS detection so the correct shared library extension is used.
|
The Windows part there is broken, as it's named Also, the (as a minor point, it also adds ~4ms to every single |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
makefilewas assuming that the shared libarary extension would always be.so, which is not accurate. On Darwin in particular, the default shared library extension is.dylib. This commit adds proper OS detection so the correct shared library extension is used.