Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature/netbox_device_custom_fields] added support custom_fields for… #242

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

doncu
Copy link

@doncu doncu commented Sep 20, 2022

added support custom_fields for resource netbox_device, updated documentation. increased go version - up to 1.19 in go.mod

@fbreckle fbreckle marked this pull request as draft September 20, 2022 14:05
@doncu doncu marked this pull request as ready for review September 20, 2022 21:26
@fbreckle fbreckle added the enhancement New feature or request label Sep 26, 2022
@doncu
Copy link
Author

doncu commented Sep 27, 2022

@fbreckle hi!
can you run the pipe?
locally all tests worked correctly

@doncu
Copy link
Author

doncu commented Sep 28, 2022

@fbreckle hi!
looks like it's time to merge
can you do it?

@fbreckle
Copy link
Collaborator

github says: "This branch cannot be rebased due to conflicts"

@doncu doncu force-pushed the feature/netbox_device_custom_fields branch from 034854d to fc211c7 Compare September 28, 2022 20:13
@doncu
Copy link
Author

doncu commented Sep 28, 2022

github says: "This branch cannot be rebased due to conflicts"

@fbreckle Upss, Done!

@fbreckle
Copy link
Collaborator

fbreckle commented Oct 5, 2022

I get the following when I run the tests on my machine, but in CI this seems to work. Hmmm...

`data_source_netbox_virtual_machines_test.go:15: Step 1/5 error: After applying this test step, the plan was not empty.
stdout:

    Terraform used the selected providers to generate the following execution
    plan. Resource actions are indicated with the following symbols:
      ~ update in-place
    
    Terraform will perform the following actions:
    
      # netbox_device.test will be updated in-place
      ~ resource "netbox_device" "test" {
          ~ custom_fields  = {
              - "custom_field" = "" -> null
            }
            id             = "9"
            name           = "test-vm_ds_basic-37ix6o6u6c"
            # (7 unchanged attributes hidden)
        }
    
    Plan: 0 to add, 1 to change, 0 to destroy.`

@doncu
Copy link
Author

doncu commented Oct 6, 2022

well, locally I don't have any problems
and functional works is correct , i'm already use in my production env

@nicoovh
Copy link

nicoovh commented Oct 24, 2022

Hi there, any news from this PR?

@xabinapal
Copy link

#667 should fix the permanent diff shown in testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants