feat: Adding support for fetching avalible ip from multiple subnets.

[sanderskjulsvik]

Feature: add support for multiple subnets for available_ip_address.
This will allow the resource available_ip_address to get an ip address from a collection of ip_ranges or subnets.

This solves the problem where we have run out of IP addresses in a subnet, and now need to create more with the same IAC setup

[fbreckle]

Is this something that can be built into the existing available_ip resource?

[sanderskjulsvik]

Yes, actually. Would have to add `prefix_ids` and `ip_range_ids` to the schema and update the create function to support multiple ids. If you preferer that I can move my changes in there?

…

________________________________ From: fbreckle ***@***.***> Sent: Friday, May 3, 2024 15:21 To: e-breuninger/terraform-provider-netbox ***@***.***> Cc: Sander Skjulsvik ***@***.***>; Author ***@***.***> Subject: Re: [e-breuninger/terraform-provider-netbox] Adding support for fetching avalible ip from multiple subnets. (PR #580) Is this something that can be built into the existing available_ip resource? — Reply to this email directly, view it on GitHub<#580 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AUUXGO5XBDHJKBPLJ4AJDSDZAOFMJAVCNFSM6AAAAABHDZFELWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJTGAYDQOJZGI>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[sanderskjulsvik]

Did not get ranges to work. Got nil in payload. So I will remove the support for multiple ranges

[sanderskjulsvik]

Nvm, The nil payload was because of typo

[sanderskjulsvik]

make testacc now works on my pc @dd4253858c21c847890a202a0302cbcea255e89a.

[sanderskjulsvik]

Seems like my tests are now failing.

[sanderskjulsvik]

@fbreckle or someone else, this is ready for a review. Please let me know of you have any comments on this feature.

[fbreckle]

The errors in your test regarding custom fields are just a race condition we currently have. My guess is that it happens during parallel tests when one test introduces a custom field while your own test runs, causing the api to return an unexpected custom field in your test.
I re-ran the tests and theyre now green. Will review this this week.

[fbreckle]

Can you allow me to push to your repo? I have some changes and just found that i cannot push there.
You can set a checkbox in your PR to allow me push access to your fork. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork step 7

[sanderskjulsvik]

Hi, sorry for my delayed answer, I had a temporary distraction. We cannot give you write access to this repo, could you open a pr to my repo?

[sanderskjulsvik]

Hi, have you had a chance to take a look at my changes?

[sanderskjulsvik]

Can you allow me to push to your repo? I have some changes and just found that i cannot push there. You can set a checkbox in your PR to allow me push access to your fork. See https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request-from-a-fork step 7

Hi, is this is a blocker on your side to get this pr merged?