Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(word): validate word id in WD0601 #335

Merged
merged 7 commits into from
Nov 5, 2023
Merged

fix(word): validate word id in WD0601 #335

merged 7 commits into from
Nov 5, 2023

Conversation

CapooL
Copy link
Collaborator

@CapooL CapooL commented Oct 19, 2023 •
edited by lin594
Loading

close #331

Norton-Lin
Norton-Lin reviewed Oct 19, 2023
View reviewed changes
Copy link
Collaborator

@Norton-Lin Norton-Lin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉没什么问题

lin594
lin594 reviewed Oct 25, 2023
View reviewed changes
hinghwa-dict-backend/word/lists/view/manage_all_list.py
Comment on lines +25 to +26
for id in body["words"]:
word = Word.objects.get(id=id)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是不是只有这个是WD0601，剩下都是US0201？
那分拆一下，先只提交WD0601吧

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

确实，那我直接继续在这个PR上继续commit？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

都可以啊，或者你把这个先close了，另外开一个PR只提交这个小东西？

@lin594 lin594 changed the title bug(user, list): fix bugs in US0201 and WD0601 fix(word): validate word id in WD0601 Nov 5, 2023
@lin594 lin594 merged commit 6dfcbb8 into e-dialect:develop Nov 5, 2023
@CapooL CapooL deleted the bug branch December 6, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Norton-Lin Norton-Lin Norton-Lin left review comments

@lin594 lin594 lin594 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

词单创建 报错 但是实际创建成功
3 participants
@CapooL @lin594 @Norton-Lin