Merge pull request #941 from HoxhaEndri/master

remove disable shellcheck from installer folder scripts
e-m-b-a · Dec 13, 2023 · 7c7eb55 · 7c7eb55
2 parents 612f82e + cfdfab1
commit 7c7eb55
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/installer/IL15_emulated_checks_init.sh b/installer/IL15_emulated_checks_init.sh
@@ -112,10 +112,12 @@ IL15_emulated_checks_init() {
       fi
       # patch some code to write the history files to a subdirectory in /root
       # shellcheck disable=SC2088
+      # we do not want to expand the tilde
       if grep -q  '~/.history' ./routersploit/interpreter.py; then
         sed -i 's/~\/\.history/~\/\.routersploit\/\.history/' ./routersploit/interpreter.py
       fi
       # shellcheck disable=SC2088
+      # we do not want to expand the tilde
       if grep -q  '~/.rsf_history' ./routersploit/interpreter.py; then
         sed -i 's/~\/\.rsf_history/~\/\.routersploit\/\.rsf_history/' ./routersploit/interpreter.py
       fi

diff --git a/installer/wickStrictModeFail.sh b/installer/wickStrictModeFail.sh
@@ -37,8 +37,7 @@ wickStrictModeFail() (
     if [[ ${#BASH_ARGC[@]} -gt ${i} ]] && [[ ${#BASH_ARGV[@]} -ge $(( nextArg + BASH_ARGC[i] )) ]]; then
       for (( argsLeft = BASH_ARGC[i]; argsLeft; --argsLeft )); do
         # Note: this reverses the order on purpose
-        # shellcheck disable=SC2004
-        argsList[${argsLeft}]=${BASH_ARGV[nextArg]}
+        argsList[argsLeft]=${BASH_ARGV[nextArg]}
         (( nextArg ++ ))
       done