Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python runner module S28 #1320

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

B1TC0R3
Copy link

@B1TC0R3 B1TC0R3 commented Sep 25, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature.

  • What is the current behavior? (You can also link to an open issue here)
    EMBA cannot run Python scripts natively as modules.

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.
    This PR adds a new module ("S28_python_run") with the capability of running user-supplied python scripts as
    modules. Related to issue Python runner module #1264.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No. The module S28 is disabled in the default scan profile (default-scan.emba).
    In addition, when no Python scripts are manually specified, it will start and terminate without doing anything.

  • Other information:
    This is a continuation of pull request Add module S28_python_run #1277.
    As mentioned in my last commend there, I broke the Git history of my fork so badly that I had
    to delete the it...
    This new pull request also implements some changes I made to the logging mechanism.

@m-1-k-3
Copy link
Member

m-1-k-3 commented Dec 18, 2024

@B1TC0R3 are there any plans to finalize this PR?

@B1TC0R3
Copy link
Author

B1TC0R3 commented Dec 18, 2024

Hello and sorry for the long pause.
I have not forgotten about this yet, but had to prioritize other projects over this one after my paper was done.
Depending on how you want to handle this, we can close this PR and I will create a new one once implementation is finished or alternatively this one simply stays open as a draft. I currently don't want to make any predictions for how long I will take, as I was horribly wrong the last time already. -_-

@m-1-k-3
Copy link
Member

m-1-k-3 commented Dec 18, 2024

We can leave it open as draft or you can close it and improve it behind the scenes. Up to you.

@B1TC0R3
Copy link
Author

B1TC0R3 commented Dec 18, 2024

I will just leave it open then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants