-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/log viewer #158
Feature/log viewer #158
Conversation
3e42d1e
to
49622fd
Compare
I'll fix the linter issues in the coming days |
I tried installing watchdog, but somehow it cannot lock the pipfile:
|
Oh that's always fun when that happens.😬 One of the packages has a dependency conflict with your new one. |
Looks like this was an issue with mysqlclient. This helped my install watchdog: https://forum.codewithmosh.com/t/pipenv-install-mysql-client/20899/4 In my case, I had to change the environment variables a little: export MYSQLCLIENT_LDFLAGS='-L/usr/mysql/lib -lmysqlclient -lssl -lcrypto -lresolv'
export MYSQLCLIENT_CFLAGS='-I/usr/include/mysql/' |
49622fd
to
0ae6ed5
Compare
Implemented ansi coloring for the log viewer
will be testing the changes now |
@@ -344,6 +344,8 @@ install_embark_default(){ | |||
wget -O ./embark/static/external/scripts/bootstrap.js https://cdn.jsdelivr.net/npm/[email protected]/dist/js/bootstrap.bundle.min.js | |||
wget -O ./embark/static/external/scripts/datatable.js https://cdn.datatables.net/v/bs5/dt-1.11.2/datatables.min.js | |||
wget -O ./embark/static/external/scripts/charts.js https://cdn.jsdelivr.net/npm/[email protected]/dist/chart.min.js | |||
wget -O ./embark/static/external/scripts/base64.js https://cdn.jsdelivr.net/npm/[email protected]/+esm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add these two lines to the developer install function too, please
line 424 for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Result is looking great 👍 |
Nice work! |
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Feature
What is the current behavior? (You can also link to an open issue here)
Opening the logs, downloads the whole log file (even if it it multiple megabytes in size)
What is the new behavior (if this is a feature change)? If possible add a screenshot.
Opening the logs opens a log viewer, that only loads the last lines of the logs. You can scroll through the logs by using the arrow keys or pgup/pgdown keys
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
A little bit? The option to download logs has moved to the log viewer instead of the report overview. The report overview will only link to the new log viewer
Other information: