Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix status calc on non phase output #201

Conversation

BenediktMKuehne
Copy link
Member

@BenediktMKuehne BenediktMKuehne commented Apr 22, 2024

Fixe calculation when no phase changes occur

@BenediktMKuehne BenediktMKuehne added bug Something isn't working EMBArk labels Apr 22, 2024
@torabi12
Copy link

I think this issue belongs to this section:

image

The progress bar cannot follow the real scan's state.

@BenediktMKuehne
Copy link
Member Author

Does the PR fix the issue?
I was only able to test it on a single firmware

@torabi12
Copy link

I am going to try it, I need some days...

@torabi12
Copy link

My new test try was hanging at 46% for a day. Some Radare related processes were running and I killed them but they started again and again. So I stopped the test and restarted it with disabled S12, S13, S14, S15 and S16. I hope this outcome will be better.

@torabi12
Copy link

Sorry, but I got the same with this modified release:

image

If you need some files or info from the system please let me know...

@BenediktMKuehne
Copy link
Member Author

BenediktMKuehne commented Jun 3, 2024

Will check this
Do you have a testing firmware for me?

@torabi12
Copy link

torabi12 commented Jun 3, 2024

Will check this Do you have a testing firmware for me?

I sent it to you in email.

@BenediktMKuehne BenediktMKuehne marked this pull request as draft July 11, 2024 15:10
@BenediktMKuehne BenediktMKuehne marked this pull request as ready for review July 12, 2024 07:24
@BenediktMKuehne BenediktMKuehne merged commit 7a039fc into e-m-b-a:main Jul 12, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working EMBArk
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants