-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket 23 #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat(migration): create RequestLog table with PostgreSQL enum type for state management The migration also includes a check for the existence of the `status` enum type, ensuring it is created only if it does not already exist, and properly handles the rollback of changes. * feat(db): pull backend database configurations (#10) * yarn dependecies updated * added components for apply wfh * Modified colours for submit button * changed folder/file structure to follow coding standards * Components will adjust accordingly to screen size * Added React states for form submission * Pass data to Page render. * Fixed dependencies * Change configs for db * fix: Fixed DB connection issues * Started backend api for wfh request --------- Co-authored-by: elliot <[email protected]> * Setup navs and login * Fix Auth page and Nav Fixed the Auth Page and Nav, finishing their scaffolding * Scaffold calendar Scaffold WFH calendar for both mobile and desktop * Refinements Refine Nav and Calendar * Front end Fixes Remove dark mode Tidy up schedule Show clearer difference between am, pm and full day wfh Marked which day is today improve mobile responsiveness --------- Co-authored-by: neojw1505 <[email protected]> Co-authored-by: elliot <[email protected]> Co-authored-by: songdre123 <[email protected]>
- Added API functionality to create a new request with staff and approver details - Created request and request log records - Started implementing modal to display success or failure on request submission
- Added API functionality to create a new request with staff and approver details - Created request and request log records - Started implementing modal to display success or failure on request submission
commit afc27d7 Author: Zavier <[email protected]> Date: Sat Sep 28 23:13:02 2024 +0800 feat: create History page and add global session for employee ID (#15) * feat: added manage requests page - Added /history route to access requests - RequestEntry & RequestTable components created for history - Currently using static data from constants * feat: Integrated History page with backend - Added session global variable for employeeid - Minor UI update on history page - Updated nav bar links to apply and history page commit 9bdeb27 Author: neojw1505 <[email protected]> Date: Sat Sep 28 16:05:48 2024 +0800 chore: switch Cypress installation to Yarn commit b73b161 Author: neojw1505 <[email protected]> Date: Sat Sep 28 15:52:13 2024 +0800 feat(tests): add ScheduleSeeder in scheduleTest, fix typo in RequestLog_RequestId foreign key commit 454aeef Merge: 3cbdb22 0b1c092 Author: solai-y <[email protected]> Date: Sat Sep 28 15:07:04 2024 +0800 Merge branch 'dev_wfh' into origin/TICKET-37 commit 3cbdb22 Author: solai-y <[email protected]> Date: Sat Sep 28 15:06:58 2024 +0800 Test File for schedule commit 0b1c092 Author: neojw1505 <[email protected]> Date: Sat Sep 28 15:01:49 2024 +0800 chore(e2e): setup Cypress for end-to-end testing in Next.js app commit 1c5ad77 Author: DESKTOP-G5I4U2Q\JW <[email protected]> Date: Sat Sep 28 11:12:18 2024 +0800 fix(tests): add missing Unit folder to track unit tests commit 6530fca Author: neojw1505 <[email protected]> Date: Fri Sep 27 10:52:21 2024 +0800 test: add test cases for employee API by ID and email - Added test cases for getting employee by ID: valid, non-existing, and invalid ID scenarios. - Added test cases for getting employee by email: valid, non-existing, and invalid email format scenarios. commit bb8cf5c Author: e-tayfw <[email protected]> Date: Fri Sep 27 08:42:12 2024 +0800 feat(api): integrated backend ownSchedule api with frontend, redux global store (#13) resolved conflict with dev_wfh before making this pull request added the integrated backend ownSchedule api with the frontend, along with implementation of the new redux global store --------- Co-authored-by: songdre123 <[email protected]> Co-authored-by: solai-y <[email protected]> Co-authored-by: neojw1505 <[email protected]> Co-authored-by: Elliot Tan <[email protected]> Co-authored-by: elliot <[email protected]> commit 9c45a7d Author: neojw1505 <[email protected]> Date: Thu Sep 26 15:43:45 2024 +0800 chore(tests): remove DB_USERNAME and DB_PASSWORD from phpunit.xml commit e508ae0 Merge: 4c71ecf e43b312 Author: Elliot Tan <[email protected]> Date: Thu Sep 26 14:03:59 2024 +0800 Merge branch 'TICKET-29' into dev_wfh commit 4c71ecf Author: songdre123 <[email protected]> Date: Sun Sep 22 14:55:03 2024 +0800 Front end Fixes Remove dark mode Tidy up schedule Show clearer difference between am, pm and full day wfh Marked which day is today improve mobile responsiveness commit bfb3bdf Author: songdre123 <[email protected]> Date: Sat Sep 21 17:52:44 2024 +0800 Refinements Refine Nav and Calendar commit 3e87fe5 Author: songdre123 <[email protected]> Date: Sat Sep 21 14:36:29 2024 +0800 Scaffold calendar Scaffold WFH calendar for both mobile and desktop commit ae10f6b Author: songdre123 <[email protected]> Date: Fri Sep 20 09:37:32 2024 +0800 Fix Auth page and Nav Fixed the Auth Page and Nav, finishing their scaffolding commit 3ccff0f Author: songdre123 <[email protected]> Date: Thu Sep 19 01:40:09 2024 +0800 Setup navs and login commit 7f7964d Author: Elliot Tan <[email protected]> Date: Tue Sep 24 20:35:16 2024 +0800 feat(db): pull backend database configurations (#10) * yarn dependecies updated * added components for apply wfh * Modified colours for submit button * changed folder/file structure to follow coding standards * Components will adjust accordingly to screen size * Added React states for form submission * Pass data to Page render. * Fixed dependencies * Change configs for db * fix: Fixed DB connection issues * Started backend api for wfh request --------- Co-authored-by: elliot <[email protected]> commit e7ea312 Author: neojw1505 <[email protected]> Date: Tue Sep 24 14:18:29 2024 +0800 feat(migration): create RequestLog table with PostgreSQL enum type for state management The migration also includes a check for the existence of the `status` enum type, ensuring it is created only if it does not already exist, and properly handles the rollback of changes.
…nt simulated API response scenarios
…rom home Untested, need to populate DB to test.
Tested and added into postman all test cases Also created scaffold for the approve request
Tests for -check if the requst is already approved -check if the person rejecting the request is the approver -check for 50% rule violation
Prevents requests that are from batch requests from being approved or rejected individually
- Added APIs to handle staff withdraw requests with different statuses - Implemented status transitions like 'Withdraw Pending', 'Withdrawn', and 'Rejected' - Created test cases to validate API behavior for all scenarios
Invalid ID: returns code 404 Success: returns code 200 Repeated request made: returns code 400 invalid date format: returns code 400
… cases - Refactored the withdrawRequest API to use a payload with Request_ID, Employee_ID, and Reason. - Rewrote the test cases to support the new payload structure for the withdrawRequest API. - Included Request_ID in the createRequest API response for consistency. - Refactored the withdrawRequest API to use a payload with Request_ID, Employee_ID, and Reason. - Rewrote the test cases to support the new payload structure for the withdrawRequest API. - Included Request_ID in the createRequest API response for consistency.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
e-tayfw
approved these changes
Oct 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes approved for this ticket. Only feedback is, in the future do try to remove any eslint issues or any unused variables, or edit wrongly typed variables before pushing or pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.