improving stability and giving hints about possible problems #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlohmeier
reviewed
Jan 17, 2025
| if np.any(mask_tr): | ||
| node_pit = net["_pit"]["node"] | ||
| fn = hc_pit[:, FROM_NODE].astype(int) | ||
| mask_err = treturn + 15 >= node_pit[fn, TINIT] |
There was a problem hiding this comment.
I think that this value of 15K could influence the user to think that a high temperature difference is generally better, although it is purely a matter of the total constellation. Having t_return <= t_in is generally bad, but I would prefer to shift finding a suitable initial temperature difference to a potential diagnostic function.
There was a problem hiding this comment.
Sounds good to me. Okay, then I will remove this from here.
dlohmeier
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.