[Annotations listing page] unskip flaky test (elastic#190053)

Fixes elastic#168281 Fixes elastic#190030 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6706 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/6718
e40pud · Aug 8, 2024 · ef8caa8 · ef8caa8
1 parent edf5c76
commit ef8caa8
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 7 deletions.
diff --git a/test/functional/apps/visualize/group3/_annotation_listing.ts b/test/functional/apps/visualize/group3/_annotation_listing.ts
@@ -18,8 +18,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const retry = getService('retry');
   const log = getService('log');
 
-  // Failing: See https://github.com/elastic/kibana/issues/168281
-  describe.skip('annotation listing page', function () {
+  describe('annotation listing page', function () {
     before(async function () {
       await kibanaServer.importExport.load(
         'test/functional/fixtures/kbn_archiver/annotation_listing_page_search'
@@ -49,8 +48,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
         await listingTable.clearSearchFilter();
       });
 
-      // FLAKY: https://github.com/elastic/kibana/issues/168281
-      describe.skip('by text', () => {
+      describe('by text', () => {
         it('matches on the first word', async function () {
           await retry.try(async () => {
             await listingTable.searchForItemWithName('search');

diff --git a/test/functional/services/listing_table.ts b/test/functional/services/listing_table.ts
@@ -85,7 +85,7 @@ export class ListingTableService extends FtrService {
   }
 
   public async waitUntilTableIsLoaded() {
-    return this.retry.try(async () => {
+    await this.retry.try(async () => {
       const isLoaded = await this.find.existsByDisplayedByCssSelector(
         '[data-test-subj="itemsInMemTable"]:not(.euiBasicTable-loading)'
       );
@@ -264,6 +264,10 @@ export class ListingTableService extends FtrService {
 
       await searchFilter.type(name);
       await this.common.pressEnterKey();
+      const filterValue = await this.getSearchFilterValue();
+      if (filterValue !== name) {
+        throw new Error(`the input value has not updated properly`);
+      }
     });
 
     await this.waitUntilTableIsLoaded();

diff --git a/x-pack/test/functional/apps/lens/group2/fields_list.ts b/x-pack/test/functional/apps/lens/group2/fields_list.ts
@@ -20,8 +20,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
   const queryBar = getService('queryBar');
   const dataViews = getService('dataViews');
 
-  // Failing: See https://github.com/elastic/kibana/issues/190030
-  describe.skip('lens fields list tests', () => {
+  describe('lens fields list tests', () => {
     for (const datasourceType of ['form-based', 'ad-hoc', 'ad-hoc-no-timefield']) {
       describe(`${datasourceType} datasource`, () => {
         before(async () => {
@@ -48,6 +47,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
             await fieldEditor.typeScript("emit('abc')");
             await fieldEditor.save();
             await PageObjects.header.waitUntilLoadingHasFinished();
+            await testSubjects.missingOrFail('fieldEditor');
           });
         });
         it('should show all fields as available', async () => {