Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(intl): override fr-CA date format #2210

Merged
merged 2 commits into from
Jul 10, 2024
Merged

Conversation

LuLaValva
Copy link
Member

@LuLaValva LuLaValva commented Jul 8, 2024

Description

  • CLDR uses ISO format for fr-CA, but eBay uses dd/mm/yyyy. This change is for consistency with eBay instead of the international standard.

Screenshots

image image

@LuLaValva LuLaValva requested a review from agliga July 8, 2024 18:08
@LuLaValva LuLaValva self-assigned this Jul 8, 2024
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 0ecf6a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga
Copy link
Contributor

agliga commented Jul 9, 2024

Lets target 14.1.0, good to merge though.

@LuLaValva LuLaValva changed the base branch from master to 14.1.0 July 9, 2024 18:01
@LuLaValva LuLaValva merged commit b07c1a3 into 14.1.0 Jul 10, 2024
4 checks passed
@LuLaValva LuLaValva deleted the 2369-fr-format-override branch July 10, 2024 22:35
@github-actions github-actions bot mentioned this pull request Jul 10, 2024
agliga pushed a commit that referenced this pull request Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ebay-date-textbox: date format incorrect for fr-CA locale
2 participants