Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add back tranmutex #153

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add back tranmutex #153

wants to merge 2 commits into from

Commits on Sep 10, 2021

  1. Reintroduce tranmutex as RW mutex 

    Mutex is needed to protect client usage when client may be nil during a
reconnect. Otherwise the code will panic in multiple places.

Co-authored-by: Surya Seetharaman <[email protected]>

Signed-off-by: Tim Rozet <[email protected]>
    @trozet
    trozet committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1e18e14 View commit details
    Browse the repository at this point in the history

  2. Close rpc2 client connection during txn error 

    This is a workaround due to a bug in ovsdb-server where it may silently
drop monitors:
https://bugzilla.redhat.com/show_bug.cgi?id=2000375

Related to ovnkube bug:
https://bugzilla.redhat.com/show_bug.cgi?id=1998614

tl;dr ovsdb-server may drop the monitor to go-ovn silently which will
cause the go-ovn cache to go stale. Subsequent retry txns for the
resource will result in errors from ovsdb-server (since the resource may
have been created in ovsdb, but we are not getting updates) threfore a
txn error is encountered force reconnect to rebuild cache and get a new
monitor.

Co-authored-by: Surya Seetharaman <[email protected]>

Signed-off-by: Tim Rozet <[email protected]>
    @trozet
    trozet committed Sep 10, 2021
    Configuration menu
    Copy the full SHA
    1233cdf View commit details
    Browse the repository at this point in the history