-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
qos support #34
qos support #34
Conversation
@softwarejl pointer used to distinguish 0 vs unset param. Without it we always need to create rule with priority 0 if user not specify, i don't know what right solution.... |
my mistake, this is mandatory param, so pointer not needed. i'm fix it for creating, but for deleting i need pointer... |
return nil, ErrorNotFound | ||
} | ||
|
||
for _, drows := range cacheLogicalSwitch { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is it possible to have common function for that, so many duplicated code now.
interface := drows.Fields["xxxx"]
interface.(type)
switch.....
not sure it works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm try to think about this, but now i don't know how to do that.
@softwarejl i have trouble for qos deletion, as i see ovn-nbctl send this request:
I'm delete 3 qos rules from logical switch. i dont understand how best to send this via mutation |
@softwarejl @hzhou8 as i see qos test run without errors now, and api mimics ovn-nbctl. |
Signed-off-by: Vasiliy Tolstov <[email protected]>
Signed-off-by: Vasiliy Tolstov <[email protected]>
i'm rebase and add comments |
No description provided.