Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qos support #34

Merged
merged 2 commits into from
Mar 25, 2019
Merged

qos support #34

merged 2 commits into from
Mar 25, 2019

Conversation

vtolstov
Copy link
Contributor

No description provided.

@vtolstov
Copy link
Contributor Author

@softwarejl pointer used to distinguish 0 vs unset param. Without it we always need to create rule with priority 0 if user not specify, i don't know what right solution....

@vtolstov
Copy link
Contributor Author

vtolstov commented Mar 22, 2019

@softwarejl pointer used to distinguish 0 vs unset param. Without it we always need to create rule with priority 0 if user not specify, i don't know what right solution....

my mistake, this is mandatory param, so pointer not needed. i'm fix it for creating, but for deleting i need pointer...

qos.go Outdated Show resolved Hide resolved
return nil, ErrorNotFound
}

for _, drows := range cacheLogicalSwitch {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it possible to have common function for that, so many duplicated code now.

interface := drows.Fields["xxxx"]
interface.(type)
switch.....

not sure it works.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm try to think about this, but now i don't know how to do that.

acl.go Outdated Show resolved Hide resolved
@vtolstov
Copy link
Contributor Author

vtolstov commented Mar 22, 2019

@softwarejl i have trouble for qos deletion, as i see ovn-nbctl send this request:

2019-03-22T17:05:34Z|00024|jsonrpc|DBG|unix:/var/run/openvswitch/ovnnb_db.sock: send request, method="transact", params=["OVN_Northbound",{"rows":[{"qos_rules":["set",[["uuid","199ba4ba-8cc6-44ef-abab-42b94d078650"],["uuid","25695f8d-d1e3-4381-9973-adc841b3a00c"],["uuid","f20a496c-440f-4fa7-abaf-28b7743699dc"]]]}],"until":"==","where":[["_uuid","==",["uuid","83e587e9-00da-42e3-b0a8-631174ae71c8"]]],"columns":["qos_rules"],"timeout":0,"op":"wait","table":"Logical_Switch"},{"where":[["_uuid","==",["uuid","83e587e9-00da-42e3-b0a8-631174ae71c8"]]],"row":{"qos_rules":["set",[]]},"op":"update","table":"Logical_Switch"},{"comment":"ovs-nbctl: ovn-nbctl -v qos-del TEST_LSW to-lport","op":"comment"}], id=4

I'm delete 3 qos rules from logical switch. i dont understand how best to send this via mutation

@vtolstov
Copy link
Contributor Author

@softwarejl @hzhou8 as i see qos test run without errors now, and api mimics ovn-nbctl.

Signed-off-by: Vasiliy Tolstov <[email protected]>
@vtolstov
Copy link
Contributor Author

vtolstov commented Mar 24, 2019

i'm rebase and add comments

@softwarejl softwarejl merged commit bbc6c45 into eBay:master Mar 25, 2019
@vtolstov vtolstov deleted the qos branch March 25, 2019 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants