Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update Design System name mapping for modules #2373

Merged
merged 6 commits into from
Jul 30, 2024
Merged

Conversation

cordeliadillon
Copy link
Contributor

@cordeliadillon cordeliadillon commented Jul 3, 2024

Addresses #2371

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

Update a few modules' Design System component name mappings to match our latest Design System canonical names, so we can accurately query for component status. Simplify this mapping by removing the optional group field, which our Component Status API can infer from name.

Notes

Screenshots

N/A

Checklist

  • I verify the build is in a non-broken state
  • I verify all changes are within scope of the linked issue

Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 5b79da9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@agliga agliga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall, but can we get this synced up with 18.1.0

@cordeliadillon
Copy link
Contributor Author

@agliga Rebased on latest 18.1.0! I also removed the group field from this YAML metadata, as it is no longer used.

src/tokens/evo-light.css Outdated Show resolved Hide resolved
@agliga agliga merged commit c09c885 into 18.1.0 Jul 30, 2024
3 checks passed
@agliga agliga deleted the 2371-component-name branch July 30, 2024 03:02
This was referenced Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants