Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(star-rating): fixed variable to compile #2375

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented Jul 8, 2024

  • This PR contains CSS changes
  • This PR does not contain CSS changes

Description

  • Updated star rating to properly parse variable

Checklist

  • I verify the build is in a non-broken state

  • I verify all changes are within scope of the linked issue

  • I regenerated all CSS files under dist folder

  • I tested the UI in all supported browsers

  • I did a visual regression check of the components impacted by doing a Percy build and approved the build

  • I tested the UI in dark mode and RTL mode

  • I added/updated/removed Storybook coverage as appropriate

@agliga agliga requested a review from ArtBlue July 8, 2024 16:43
@agliga agliga self-assigned this Jul 8, 2024
Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 08bf2ab

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/skin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agliga agliga merged commit e0d7948 into master Jul 9, 2024
@agliga agliga deleted the star-rating-compile branch July 9, 2024 17:00
@github-actions github-actions bot mentioned this pull request Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants