[20274] Validate the YAML configuration file on parsing #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciaEchevarria99
requested changes
Apr 8, 2024
Tempate
force-pushed
the
feature/yaml_validator
branch
from
5073eb6
to
6dd9484
Compare
Tempate
force-pushed
the
feature/yaml_validator
branch
from
6dd9484
to
d2c218b
Compare
Tempate
force-pushed
the
feature/yaml_validator
branch
from
d2c218b
to
25a6936
Compare
Tempate
force-pushed
the
feature/yaml_validator
branch
from
25a6936
to
3b77e66
Compare
LuciaEchevarria99
requested changes
Jul 18, 2024
ddsrecorder_yaml/include/ddsrecorder_yaml/recorder/YamlReaderConfiguration.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: tempate <[email protected]> Validate YAML tags on parsing Signed-off-by: tempate <[email protected]> Validate new YAML options Signed-off-by: tempate <[email protected]> Make sets static Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
Signed-off-by: tempate <[email protected]>
LuciaEchevarria99
force-pushed
the
feature/yaml_validator
branch
from
fb34fba
to
36e33f9
Compare
LuciaEchevarria99
had a problem deploying
to
codecov
GitHub Actions
Failure
juanlofer-eprosima
requested changes
Sep 20, 2024
| @@ -337,10 +378,60 @@ void RecorderConfiguration::load_recorder_configuration_( | |||
| } | |||
| } | |||
|
|
|||
| void RecorderConfiguration::load_output_configuration_( | |||
There was a problem hiding this comment.
You are not using this method, delete it or complete it.
| int exit(ProcessReturnCode code) | ||
| { | ||
| // Delete the consumers before closing | ||
| eprosima::utils::Log::ClearConsumers(); |
There was a problem hiding this comment.
Shouldn't this flush as well?
There was a problem hiding this comment.
Apparently it is called in ClearConsumers , so I guess not.
Comment on lines
+204
to
+209
| // NOTE: | ||
| // It will not filter any log, so Fast DDS logs will be visible unless Fast DDS is compiled | ||
| // in non debug or with LOG_NO_INFO=ON. | ||
| // This is the easiest way to allow to see Warnings and Errors from Fast DDS. | ||
| // Change it when Log Module is independent and with more extensive API. | ||
| // utils::Log::SetCategoryFilter(std::regex("(DDSRECORDER)")); |
There was a problem hiding this comment.
Does this note make sense anymore?
| }; | ||
|
|
||
| YamlValidator::validate_tags(yml, tags); | ||
|
|
||
| mcap::McapWriterOptions mcap_writer_options{"ros2"}; |
There was a problem hiding this comment.
Inner tags are not validated right?
There was a problem hiding this comment.
I believe they are
| @@ -136,7 +149,6 @@ void RecorderConfiguration::load_ddsrecorder_configuration_( | |||
|
|
|||
| ///// | |||
| // Get optional specs configuration | |||
| // WARNING: Parse builtin topics (dds tag) AFTER specs, as some topic-specific default values are set there | |||
There was a problem hiding this comment.
I think this warning is important, I would update it not delete it.
|
|
||
| This release includes the following **Recording features**: | ||
|
|
||
| * :ref:`Resource Limits <recorder_specs_logging>`. |
Signed-off-by: Lucia Echevarria <[email protected]>
LuciaEchevarria99
had a problem deploying
to
codecov
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this version, the DDS Recorder and the DDS Replayer throw a warning when a YAML tag is ignored to prevent typos, misplacements, and wrong configurations.
Merge after: