New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abort when the max_file_size is too small #150

Open

Tempate wants to merge 2 commits into main from hotfix/mcap_writer_error_handling

Contributor

Tempate commented Jul 9, 2024 •

edited

Loading

This PR fixes two minor bugs:

Before, when the size of a dataless MCAP file was larger than the max_file_size, the McapWriter was not capturing the error correctly and kept trying to write data to it. Now, the McapWriter aborts as if the disk was full.
Before, the McapWriter attempted to write to the MCAP file even after the file was closed. Now, if the McapWriter fails to open a new file, it will never try to write to it.

Tempate added 2 commits

July 9, 2024 11:34


          Fix - Stop writing when a dataless file is larger than the max_file_size

18fa012

Signed-off-by: tempate <[email protected]>


          Fix - Don't try to write when the MCAP file is closed

df22388

Signed-off-by: tempate <[email protected]>

Tempate had a problem deploying to codecov

July 9, 2024 10:37

— with

GitHub Actions Failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet