Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some rosdep keys #335

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix some rosdep keys #335

wants to merge 3 commits into from

Conversation

artivis
Copy link

@artivis artivis commented Jan 18, 2023

Fix some rosdep keys,

Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@artivis artivis temporarily deployed to codecov January 18, 2023 08:49 — with GitHub Actions Inactive
@jparisu
Copy link
Contributor

jparisu commented Jan 18, 2023

@artivis thank you for your contribution. We will study more in detail these key-words and we will merge your PR once we finish.

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Base: 45.58% // Head: 45.52% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (bbde3a1) compared to base (f9d69c5).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #335      +/-   ##
==========================================
- Coverage   45.58%   45.52%   -0.06%     
==========================================
  Files          85       85              
  Lines        3422     3422              
  Branches     1345     1345              
==========================================
- Hits         1560     1558       -2     
- Misses       1165     1166       +1     
- Partials      697      698       +1     
Impacted Files Coverage Δ
ddsrouter_core/src/cpp/communication/Track.cpp 61.42% <0.00%> (-2.86%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants