Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support of external members [19704] #170

Merged
merged 3 commits into from
Oct 24, 2023
Merged

Support of external members [19704] #170

merged 3 commits into from
Oct 24, 2023

Conversation

richiware
Copy link
Member

No description provided.

@richiware
Refs #19697. External template and api tests
6d327b4 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Refs #19697. Encode/decode external
254e5d6 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Support of external members Support of external members [19704] Oct 10, 2023
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware richiware mentioned this pull request Oct 13, 2023
Merged
@JLBuenoLopez
Copy link
Contributor

Manual CI run: SUCCESS

JLBuenoLopez
JLBuenoLopez suggested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few typos in the comments. Implementation LGTM!

include/fastcdr/xcdr/external.hpp Outdated Show resolved Hide resolved
include/fastcdr/xcdr/external.hpp Outdated Show resolved Hide resolved
test/xcdr/external.cpp Outdated Show resolved Hide resolved
test/xcdr/external.cpp Outdated Show resolved Hide resolved
test/xcdr/external.cpp Outdated Show resolved Hide resolved
test/xcdr/external.cpp Outdated Show resolved Hide resolved
@richiware
Refs #19697. Apply suggestions
0f9a604 
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiprosima
Copy link
Contributor

Build status:

  • Linux Build Status
  • Mac Build Status
  • Windows Build Status

@richiware
Copy link
Member Author

Relaunched Mac job success: link

JLBuenoLopez
JLBuenoLopez approved these changes Oct 24, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit 92021a8 into master Oct 24, 2023
@richiware richiware deleted the feature/external branch October 24, 2023 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@richiware @richiprosima @JLBuenoLopez