Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support @optional and @extensibility annotations [19390] #208

Merged
merged 50 commits into from
Sep 12, 2023

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 27, 2023

@JLBuenoLopez JLBuenoLopez mentioned this pull request Aug 21, 2023
1 task
@JLBuenoLopez JLBuenoLopez linked an issue Aug 21, 2023 that may be closed by this pull request
1 task
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of new suggestions and I have kept unresolved some suggestions that I think that have been overlooked.

.github/workflows/ci.yaml Show resolved Hide resolved
@richiware
Copy link
Member Author

Ci passed in this action.

richiware and others added 2 commits September 7, 2023 12:24
…ader.stg

Co-authored-by: José Luis Bueno López <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware force-pushed the feature/xcdr branch 5 times, most recently from 0404bc4 to 425dc33 Compare September 8, 2023 10:37
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

richiware commented Sep 8, 2023

CI passed in this action

Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
@richiware
Copy link
Member Author

CI passed in this action

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware
Copy link
Member Author

Ci passed in this action

Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is still one template which has not been updated to ST4: src/main/java/com/eprosima/fastdds/idl/templates/makefile.stg. This template is only generated with the -example option using any of the *Linux* platforms. Those platforms are not going to be supported so maybe we can remove this code. I am OK if it is done in a follow-up PR.

resources/Custom.stg Show resolved Hide resolved
Signed-off-by: Ricardo González Moreno <[email protected]>
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@richiware richiware merged commit e9c578a into master Sep 12, 2023
1 of 5 checks passed
@richiware richiware deleted the feature/xcdr branch September 12, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use virtual or override, not both bitset implementation
3 participants