-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support @optional and @extensibility annotations [19390] #208
Conversation
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
4ab6a36
to
e39e2b3
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
e39e2b3
to
e51754d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of new suggestions and I have kept unresolved some suggestions that I think that have been overlooked.
src/main/java/com/eprosima/fastdds/idl/templates/TypesCdrAuxHeader.stg
Outdated
Show resolved
Hide resolved
Ci passed in this action. |
…ader.stg Co-authored-by: José Luis Bueno López <[email protected]> Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
cd40add
to
a0f3883
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
0404bc4
to
425dc33
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
425dc33
to
91f79e0
Compare
CI passed in this action ✅ |
Signed-off-by: Ricardo González <[email protected]>
Signed-off-by: Ricardo González <[email protected]>
CI passed in this action ✅ |
Signed-off-by: Ricardo González Moreno <[email protected]>
Ci passed in this action ✅ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is still one template which has not been updated to ST4: src/main/java/com/eprosima/fastdds/idl/templates/makefile.stg
. This template is only generated with the -example
option using any of the *Linux*
platforms. Those platforms are not going to be supported so maybe we can remove this code. I am OK if it is done in a follow-up PR.
Signed-off-by: Ricardo González Moreno <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Depends on: