Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require minimum versions on CMakeLists template. #224

Merged
merged 2 commits into from
Sep 13, 2023
Merged

Require minimum versions on CMakeLists template. #224

merged 2 commits into from
Sep 13, 2023

Conversation

MiguelCompany
Copy link
Member

The code generated is now designed for Fast CDR >= 2.0 and Fast DDS >= 2.12, so the generated CMakeLists.txt should require those versions.

JLBuenoLopez
JLBuenoLopez suggested changes Sep 13, 2023
View reviewed changes
thirdparty/idl-parser Outdated Show resolved Hide resolved
richiware
richiware requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, increase cmake_minimum_required to 3.22 as fastcdr and fastdds.

cmake_minimum_required(VERSION 3.22)

@MiguelCompany
Require minimum versions on CMakeLists template.
cc9171a 
The code generated is now designed for Fast CDR >= 2.0 and Fast DDS >= 2.12,
so the generated CMakeLists.txt should require those versions.

Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany force-pushed the hotfix/cmake-example-package-versions branch from 8eae760 to cc9171a Compare September 13, 2023 06:52
@MiguelCompany
Copy link
Member Author

Please, increase cmake_minimum_required to 3.22 as fastcdr and fastdds.

cmake_minimum_required(VERSION 3.22)

404ab20

JLBuenoLopez
JLBuenoLopez approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Changes are not tested on CI. So I think this is ready to be merged.

@MiguelCompany MiguelCompany merged commit bbf3cb1 into master Sep 13, 2023
1 of 5 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/cmake-example-package-versions branch September 13, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware requested changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiguelCompany @richiware @JLBuenoLopez