Maintain xtypes serialization to previous encoding version to maintain interop [19624] #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
changed the title
JLBuenoLopez
suggested changes
Sep 29, 2023
There was a problem hiding this comment.
Changes LGTM though I have a couple of concerns:
- Generating Fast DDS types, you had to remove the brackets to build for VS2017 in this commit. Current Fast DDS-Gen still generates those brackets. We should do something about that.
- It seems that the bitset generation code is not applying the code style as it generates the following command in a single line
eProsima_user_DllExport void bitset(const std::bitset<30>&);
Signed-off-by: Ricardo González Moreno <[email protected]>
JLBuenoLopez
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also this PR fix warning with arrays' initial value and fix the end of two files.