Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support union discriminator's @default annotation #361

Merged
merged 2 commits into from
Jul 8, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented Jun 24, 2024

Description

This PR adds support for union discriminator's @default annotation.

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware added this to the v4.0.0 milestone Jun 24, 2024
@richiware richiware force-pushed the feature/21222 branch 2 times, most recently from bcb92e7 to 7fd410e Compare June 27, 2024 13:44
MiguelCompany
MiguelCompany previously approved these changes Jul 1, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 5, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware requested review from MiguelCompany and removed request for MiguelCompany July 8, 2024 06:29
@MiguelCompany MiguelCompany added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 8, 2024
@richiware richiware merged commit 08950fb into master Jul 8, 2024
4 checks passed
@richiware richiware deleted the feature/21222 branch July 8, 2024 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants