Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21226] Improve CI workflows in master, and branching model refactor #371

Merged
merged 6 commits into from
Jul 5, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 4, 2024

Description

This PR improves the CI workflows, making them as similar as possible to the Fast DDS workflows.
It also introduces a braching model refactor, similiar as the performed in Fast DDS repository.

Note: While backporting this PR, please ensure the following changes:

  • Remove nightly jobs
  • Update ubuntu-ci.yml file with the proper fallback branches
  • Change fastdds.repos to fastrtps.repos
  • 3.3.x and 3.2.x requires both 1.1.x and 2.x Fast CDR branches to be tested
  • 2.5.x requires only jdk11
  • 2.1.x requires building on ubuntu-20.04, and only jdk11

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v4.0.0 milestone Jul 4, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 4, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 4, 2024
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 5, 2024
@JesusPoderoso JesusPoderoso merged commit bd44d84 into master Jul 5, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/21226 branch July 5, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants