Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21347] Fix generation for new kind of constants #374

Merged
merged 1 commit into from
Jul 26, 2024
Merged

[21347] Fix generation for new kind of constants #374

merged 1 commit into from
Jul 26, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 11, 2024 •
edited by EduPonz
Loading

Description

Fixes #373

Depends on:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Fix generation for new kind of constants Fix generation for new kind of constants [21347] Jul 11, 2024
@richiware richiware changed the title Fix generation for new kind of constants [21347] [21347] Fix generation for new kind of constants Jul 11, 2024
@richiware richiware requested a review from EduPonz July 11, 2024 10:43
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 11, 2024
@EduPonz EduPonz added this to the v4.0.0 milestone Jul 18, 2024
@richiware richiware requested review from EduPonz and removed request for EduPonz July 26, 2024 06:41
@richiware
Refs #21343. Submodules with fix
d0c7cb4 
Signed-off-by: Ricardo González Moreno <[email protected]>
@EduPonz EduPonz requested review from EduPonz and removed request for EduPonz July 26, 2024 08:30
EduPonz
EduPonz approved these changes Jul 26, 2024
View reviewed changes
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@EduPonz EduPonz merged commit a619e41 into master Jul 26, 2024
4 checks passed
@EduPonz EduPonz deleted the bugfix/21343 branch July 26, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v4.0.0
2 participants
@richiware @EduPonz