Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21324] Adapt example generation to Fast DDS examples refactor #377

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 15, 2024

Description

The Fast DDS examples have been refactored, making them homogeneous and more self-explained, with an improved README markdown file and best practices usage.
This PR introduces the same structure in the Fast DDS Gen generated examples.
Tested locally

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v4.0.0 milestone Jul 15, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 15, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 17, 2024
@JesusPoderoso JesusPoderoso requested review from MiguelCompany and removed request for MiguelCompany July 17, 2024 14:32
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 17, 2024
@JesusPoderoso JesusPoderoso merged commit 78da8ab into master Jul 17, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/21324 branch July 17, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants