Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21366] Bump to v4.0.0 #387

Merged
merged 3 commits into from
Aug 5, 2024
Merged

[21366] Bump to v4.0.0 #387

merged 3 commits into from
Aug 5, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 29, 2024 •
edited by Mario-DL
Loading

Description

This PR bumps to Fast DDS gen v4.0.0

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v4.0.0 milestone Jul 29, 2024
Mario-DL
Mario-DL previously approved these changes Aug 2, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Mario-DL
Copy link
Member

Mario-DL commented Aug 5, 2024

Commit updating idl-parser submodule is required

@github-actions github-actions bot added the ci-pending PR which CI is running label Aug 5, 2024
Mario-DL
Mario-DL approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Aug 5, 2024
@JesusPoderoso JesusPoderoso merged commit 541129f into master Aug 5, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the release/v4.0.0 branch August 5, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @Mario-DL @JesusPoderoso