Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21625] Fix warning on Windows #396

Merged
merged 1 commit into from
Sep 11, 2024
Merged

[21625] Fix warning on Windows #396

merged 1 commit into from
Sep 11, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Sep 10, 2024

Description

This PR fixes next warning:

constantsPubSubTypes.cxx
  D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constants.hpp(60,31): error C2220: the following warning is treated as an error (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constantsPubSubTypes.cxx) [D:\a\Fast-DDS\Fast-DDS\build\fastdds\test\dds\xtypes\DDSXtypesCommunication.vcxproj]
  [Processing: fastdds]
  D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constants.hpp(60,31): warning C4305: 'initializing': truncation from 'double' to 'float' (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constantsPubSubTypes.cxx) [D:\a\Fast-DDS\Fast-DDS\build\fastdds\test\dds\xtypes\DDSXtypesCommunication.vcxproj]
    constantsTypeObjectSupport.cxx
    declarationsPubSubTypes.cxx
  D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constants.hpp(60,31): error C2220: the following warning is treated as an error (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constantsTypeObjectSupport.cxx) [D:\a\Fast-DDS\Fast-DDS\build\fastdds\test\dds\xtypes\DDSXtypesCommunication.vcxproj]
  D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constants.hpp(60,31): warning C4305: 'initializing': truncation from 'double' to 'float' (compiling source file D:\a\Fast-DDS\Fast-DDS\src\fastdds\test\dds-types-test\constantsTypeObjectSupport.cxx) [D:\a\Fast-DDS\Fast-DDS\build\fastdds\test\dds\xtypes\DDSXtypesCommunication.vcxproj]

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Ricardo González Moreno <[email protected]>
@richiware richiware changed the title Fix warning on Windows [21625] Fix warning on Windows Sep 10, 2024
@richiware richiware added this to the v4.0.1 milestone Sep 10, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 10, 2024
@richiware richiware merged commit dc85a19 into master Sep 11, 2024
4 checks passed
@richiware richiware deleted the bugfix/20165 branch September 11, 2024 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants