Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21592] Test generation of types with -python in ci #399

Merged
merged 1 commit into from
Sep 18, 2024
Merged

[21592] Test generation of types with -python in ci #399

merged 1 commit into from
Sep 18, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Sep 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR introduces a new step in CI that generates the types defined in dds-type-tests with -python arg for checking failures.

Susccessfull generation (after the fix in #294): here
Failing run (before the fix in the previous PR): here

Note: we may add backports

@Mergifyio backport 3.3.x 2.5.x 2.1.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v4.0.2 milestone Sep 16, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Sep 17, 2024
@MiguelCompany
Copy link
Member

@Mergifyio backport 3.3.x 2.5.x 2.1.x

@mergify Mergify
Copy link

mergify bot commented Sep 17, 2024 •
edited
Loading

backport 3.3.x 2.5.x 2.1.x

✅ Backports have been created

@Mario-DL Mario-DL merged commit e605e07 into master Sep 18, 2024
4 checks passed
@Mario-DL Mario-DL deleted the ci/generate-python branch September 18, 2024 06:06
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
f4315c1 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
a689b51 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e605e07)
This was referenced Sep 18, 2024
Open
Open
mergify bot pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @mergify
Run generation of types with -python in ci (#399)
19bb714 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e605e07)
@mergify mergify bot mentioned this pull request Sep 18, 2024
Open
7 tasks
JesusPoderoso pushed a commit that referenced this pull request Sep 18, 2024
@Mario-DL @JesusPoderoso
Run generation of types with -python in ci (#399)
cafcdf0 
Signed-off-by: Mario Dominguez <[email protected]>
(cherry picked from commit e605e07)

# Conflicts:
#	.github/workflows/reusable-ubuntu-ci.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v4.0.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @MiguelCompany