Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20631] Update xtypes 1.3 doc #730

Merged
merged 23 commits into from
Apr 16, 2024
Merged

[20631] Update xtypes 1.3 doc #730

merged 23 commits into from
Apr 16, 2024

Conversation

adriancampo
Copy link
Contributor

@adriancampo adriancampo commented Mar 17, 2024 •
edited by JLBuenoLopez
Loading

This PR updates the documentation related to XTypes1.3.

This PR depends on both:
eProsima/Fast-DDS#4240
eProsima/Fast-DDS-Gen#319

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@adriancampo adriancampo force-pushed the feature/xtypes1.3 branch 3 times, most recently from 982abc0 to 2d178cd Compare March 17, 2024 09:37
@adriancampo adriancampo changed the base branch from master to 3.0.x-devel March 17, 2024 09:37
@adriancampo adriancampo force-pushed the feature/xtypes1.3 branch 2 times, most recently from d9e73f9 to b89e910 Compare March 17, 2024 10:22
@richiware
Copy link
Member

Please, change dynamic_types folder name to xtypes.

richiware
richiware requested changes Mar 18, 2024
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First general review.

docs/fastdds/dynamic_types/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/dynamic_types/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/dynamic_types/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/dynamic_types/discovery_matching.rst Outdated Show resolved Hide resolved
richiware
richiware requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review about discovery

docs/fastdds/xtypes/xtypes.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/xtypes.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/xtypes.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/xtypes.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
richiware
richiware requested changes Mar 20, 2024
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review of language binding

docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
@adriancampo adriancampo force-pushed the feature/xtypes1.3 branch 2 times, most recently from 41f6ef3 to e38d0d8 Compare March 22, 2024 06:24
@EduPonz EduPonz added this to the v3.0.0 milestone Mar 27, 2024
adriancampo and others added 8 commits April 4, 2024 09:12
@adriancampo
Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Remov…
b0e2987 
…ed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Remo…
0197949 
…ved on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: DDSCodeTester updates for DynamicTypes and discovery cal…
8964bb1 
…lbacks

Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: Updated xtypes doc.
a50e0ee 
Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: Applied first suggestions.
aaa1c9e 
Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: Updates to discovery and endpoint matching.
693c13b 
Signed-off-by: adriancampo <[email protected]>
@adriancampo @richiware
Refs #20359: Apply suggestions from code review
b9389cf 
Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>
@adriancampo
Refs #20359: Regenerated example types. Removed classes after monitor…
0ece561 
… service refactor.

Signed-off-by: adriancampo <[email protected]>
JLBuenoLopez
JLBuenoLopez suggested changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/XMLTester.xml Outdated Show resolved Hide resolved
docs/03-exports/aliases.include Outdated Show resolved Hide resolved
docs/03-exports/aliases.include Outdated Show resolved Hide resolved
docs/03-exports/aliases.include Outdated Show resolved Hide resolved
docs/fastdds/api_reference/dds_pim/xtypes/exception.rst Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez reviewed Apr 8, 2024
View reviewed changes
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial review

docs/03-exports/aliases-api.include Outdated Show resolved Hide resolved
docs/fastdds/dds_layer/domain/domainParticipant/domainParticipant.rst Show resolved Hide resolved
docs/fastdds/dds_layer/domain/domainParticipantListener/domainParticipantListener.rst Outdated Show resolved Hide resolved
docs/fastdds/dds_layer/topic/contentFilteredTopic/createContentFilteredTopic.rst Outdated Show resolved Hide resolved
docs/fastdds/dds_layer/topic/fastddsgen/fastddsgen.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/dynamic_types.rst Outdated Show resolved Hide resolved
docs/fastdds/xml_configuration/dynamic_types.rst Outdated Show resolved Hide resolved
JLBuenoLopez
JLBuenoLopez reviewed Apr 8, 2024
View reviewed changes
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/discovery_matching.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/xtypes.rst Outdated Show resolved Hide resolved
docs/fastddsgen/usage/usage.rst Outdated Show resolved Hide resolved
@JLBuenoLopez
Copy link
Contributor

@richiprosima please test_3 this

@JLBuenoLopez
Copy link
Contributor

JLBuenoLopez commented Apr 15, 2024 •
edited
Loading

Manual CI: Fast DDS Github action SUCCESS

richiware
richiware reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial revision

docs/03-exports/aliases.include Outdated Show resolved Hide resolved
docs/03-exports/aliases-api.include Outdated Show resolved Hide resolved
docs/03-exports/aliases-api.include Show resolved Hide resolved
docs/fastdds/api_reference/dds_pim/topic/typeinformation.rst Show resolved Hide resolved
docs/fastdds/api_reference/dds_pim/xtypes/exception.rst Show resolved Hide resolved
code/DDSCodeTester.cpp Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Show resolved Hide resolved
richiware
richiware requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@richiware richiware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review finished

docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
docs/fastdds/xtypes/language_binding.rst Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
docs/fastddsgen/dataTypes/dataTypes.rst Outdated Show resolved Hide resolved
docs/fastddsgen/dataTypes/dataTypes.rst Show resolved Hide resolved
docs/spelling_wordlist.txt Outdated Show resolved Hide resolved
code/XMLTesterExample.xml Show resolved Hide resolved
code/DDSCodeTester.cpp Outdated Show resolved Hide resolved
@JLBuenoLopez
Refs #20631: apply review suggestions
3d4994a 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Refs #20631: regenerate example types
9bbea0d 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Copy link
Contributor

JLBuenoLopez commented Apr 16, 2024 •
edited
Loading

Manual CI: SUCCESS

@richiware
Refs #20631: little block comment
ad0d459 
Signed-off-by: Ricardo González Moreno <[email protected]>
@JLBuenoLopez
Refs #20631: apply review suggestions
5b85989 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Copy link
Contributor

Manual CI

@JLBuenoLopez
Refs #20631: apply review suggestions
15abe6a 
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez JLBuenoLopez merged commit d74e219 into 3.0.x-devel Apr 16, 2024
3 checks passed
@JLBuenoLopez JLBuenoLopez deleted the feature/xtypes1.3 branch April 16, 2024 12:58
richiware added a commit that referenced this pull request Apr 18, 2024
@adriancampo @richiware @JLBuenoLopez
Update xtypes 1.3 doc (#730)
45edf71 
* Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Removed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Removed on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: DDSCodeTester updates for DynamicTypes and discovery callbacks

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updated xtypes doc.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Applied first suggestions.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates to discovery and endpoint matching.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Apply suggestions from code review

Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Regenerated example types. Removed classes after monitor service refactor.

Signed-off-by: adriancampo <[email protected]>

* Refs #20631: apply review suggestions to Fast DDS-Gen usage

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: inheritance not yet supported with XML. Use correct typelookup service thread name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix tests: trailing whitespaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix spelling

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: migrate to list tables and use proper C++ types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes introduction section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite remote data type discovery section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: implement pending TODO

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes sections and related information

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply remaining suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: regenerate example types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: little block comment

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: adriancampo <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
EduPonz pushed a commit that referenced this pull request Apr 24, 2024
@adriancampo @richiware
@JLBuenoLopez @EduPonz
Update xtypes 1.3 doc (#730)
1fdaf00 
* Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Removed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Removed on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: DDSCodeTester updates for DynamicTypes and discovery callbacks

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updated xtypes doc.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Applied first suggestions.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates to discovery and endpoint matching.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Apply suggestions from code review

Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Regenerated example types. Removed classes after monitor service refactor.

Signed-off-by: adriancampo <[email protected]>

* Refs #20631: apply review suggestions to Fast DDS-Gen usage

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: inheritance not yet supported with XML. Use correct typelookup service thread name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix tests: trailing whitespaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix spelling

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: migrate to list tables and use proper C++ types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes introduction section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite remote data type discovery section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: implement pending TODO

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes sections and related information

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply remaining suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: regenerate example types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: little block comment

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: adriancampo <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
EduPonz pushed a commit that referenced this pull request May 9, 2024
@adriancampo @richiware
@JLBuenoLopez @EduPonz
Update xtypes 1.3 doc (#730)
f8a6dee 
* Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Removed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Removed on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: DDSCodeTester updates for DynamicTypes and discovery callbacks

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updated xtypes doc.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Applied first suggestions.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates to discovery and endpoint matching.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Apply suggestions from code review

Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Regenerated example types. Removed classes after monitor service refactor.

Signed-off-by: adriancampo <[email protected]>

* Refs #20631: apply review suggestions to Fast DDS-Gen usage

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: inheritance not yet supported with XML. Use correct typelookup service thread name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix tests: trailing whitespaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix spelling

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: migrate to list tables and use proper C++ types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes introduction section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite remote data type discovery section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: implement pending TODO

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes sections and related information

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply remaining suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: regenerate example types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: little block comment

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: adriancampo <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: eduponz <[email protected]>
@richiware richiware mentioned this pull request May 9, 2024
Closed
EduPonz pushed a commit that referenced this pull request May 13, 2024
@adriancampo @richiware
@JLBuenoLopez @EduPonz
Update xtypes 1.3 doc (#730)
ca6618a 
* Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Removed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Removed on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: DDSCodeTester updates for DynamicTypes and discovery callbacks

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updated xtypes doc.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Applied first suggestions.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates to discovery and endpoint matching.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Apply suggestions from code review

Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Regenerated example types. Removed classes after monitor service refactor.

Signed-off-by: adriancampo <[email protected]>

* Refs #20631: apply review suggestions to Fast DDS-Gen usage

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: inheritance not yet supported with XML. Use correct typelookup service thread name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix tests: trailing whitespaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix spelling

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: migrate to list tables and use proper C++ types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes introduction section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite remote data type discovery section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: implement pending TODO

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes sections and related information

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply remaining suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: regenerate example types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: little block comment

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: adriancampo <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: eduponz <[email protected]>
EduPonz pushed a commit that referenced this pull request May 14, 2024
@adriancampo @richiware
@JLBuenoLopez @EduPonz
Update xtypes 1.3 doc (#730)
ef27e2b 
* Refs #20359: Updates for xtypes1.3. Removed TypeLookupSettings. Removed auto_fill_typeonject. Renamede discovery methods. Added typelookup_service_threads.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates fastddsgen args. Removed TypeObjectFactory. Removed on_type_discovery, on_type_dependencies_reply, on_type_information_received, register_remote_type. Updated references to DDS-XTypes V1.3.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: DDSCodeTester updates for DynamicTypes and discovery callbacks

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updated xtypes doc.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Applied first suggestions.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Updates to discovery and endpoint matching.

Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Apply suggestions from code review

Co-authored-by: Ricardo González <[email protected]>
Signed-off-by: adriancampo <[email protected]>

* Refs #20359: Regenerated example types. Removed classes after monitor service refactor.

Signed-off-by: adriancampo <[email protected]>

* Refs #20631: apply review suggestions to Fast DDS-Gen usage

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: inheritance not yet supported with XML. Use correct typelookup service thread name

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix tests: trailing whitespaces

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: fix spelling

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: migrate to list tables and use proper C++ types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes introduction section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite remote data type discovery section

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: implement pending TODO

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: rewrite XTypes sections and related information

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply remaining suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: regenerate example types

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: little block comment

Signed-off-by: Ricardo González Moreno <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

* Refs #20631: apply review suggestions

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>

---------

Signed-off-by: adriancampo <[email protected]>
Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Co-authored-by: Ricardo González <[email protected]>
Co-authored-by: JLBuenoLopez-eProsima <[email protected]>
Signed-off-by: eduponz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

@JLBuenoLopez JLBuenoLopez JLBuenoLopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@adriancampo @richiware @JLBuenoLopez @EduPonz