Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Spell Check error summary to reusable workflow #950

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Add Spell Check error summary to reusable workflow #950

merged 1 commit into from
Nov 14, 2024
+4 −0

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Nov 14, 2024 •
edited by JesusPoderoso
Loading

Description

This adds a new step to the reusable workflow that lists the spell check errors produced during the test step.
See it in action here

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Code snippets related to the added documentation have been provided.
  • Documentation tests pass locally.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@MiguelCompany MiguelCompany added this to the v3.2.0 milestone Nov 14, 2024
JesusPoderoso
JesusPoderoso approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

@mergify Mergify
Copy link

mergify bot commented Nov 14, 2024 •
edited
Loading

backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

✅ Backports have been created

@MiguelCompany MiguelCompany merged commit 96bc828 into master Nov 14, 2024
4 checks passed
@MiguelCompany MiguelCompany deleted the feature/ci-show-spell-failures branch November 14, 2024 13:44
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@MiguelCompany @mergify
Add Spell Check summary to reusable workflow (#950)
5fe393e 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@MiguelCompany @mergify
Add Spell Check summary to reusable workflow (#950)
4c1dd6d 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@MiguelCompany @mergify
Add Spell Check summary to reusable workflow (#950)
2264e82 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)
This was referenced Nov 14, 2024
Merged
Merged
Merged
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@MiguelCompany @mergify
Add Spell Check summary to reusable workflow (#950)
44013f2 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)
mergify bot pushed a commit that referenced this pull request Nov 14, 2024
@MiguelCompany @mergify
Add Spell Check summary to reusable workflow (#950)
bf2aafb 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)
This was referenced Nov 14, 2024
Merged
Merged
MiguelCompany added a commit that referenced this pull request Nov 15, 2024
@mergify @MiguelCompany
Add Spell Check summary to reusable workflow (#950) (#953)
bf27d7c 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)

Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 15, 2024
@mergify @MiguelCompany
Add Spell Check summary to reusable workflow (#950) (#951)
8679a3a 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)

Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 15, 2024
@mergify @MiguelCompany
Add Spell Check summary to reusable workflow (#950) (#952)
518874d 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)

Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 15, 2024
@mergify @MiguelCompany
Add Spell Check summary to reusable workflow (#950) (#954)
67dc7a0 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)

Co-authored-by: Miguel Company <[email protected]>
MiguelCompany added a commit that referenced this pull request Nov 15, 2024
@mergify @MiguelCompany
Add Spell Check summary to reusable workflow (#950) (#955)
d57d252 
Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 96bc828)

Co-authored-by: Miguel Company <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@MiguelCompany @JesusPoderoso