Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21373] Update to new TopicDataType functions #165

Merged
merged 2 commits into from
Jul 18, 2024
Merged

[21373] Update to new TopicDataType functions #165

merged 2 commits into from
Jul 18, 2024

Conversation

richiware
Copy link
Member

@richiware richiware commented Jul 16, 2024 •
edited by MiguelCompany
Loading

Description

This PR update the source code to new changes introduced in:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • ❌ Changes are API compatible.
  • ❌ Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Update to new TopicDataType functions [21373] Update to new TopicDataType functions Jul 16, 2024
@richiware richiware mentioned this pull request Jul 17, 2024
Merged
8 tasks
@richiware
Refs #21349. Regenerate source code
3c3ff5f 
Signed-off-by: Ricardo González Moreno <[email protected]>
@MiguelCompany MiguelCompany added this to the v2.0.0 milestone Jul 17, 2024
@richiware
Refs #21349. Fix
ddf8334 
Signed-off-by: Ricardo González Moreno <[email protected]>
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 17, 2024
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 18, 2024
@richiware richiware merged commit 691e75e into main Jul 18, 2024
6 checks passed
@richiware richiware deleted the feature/21349 branch July 18, 2024 10:40
@JesusPoderoso JesusPoderoso mentioned this pull request Aug 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@richiware @MiguelCompany