Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21808] Update DataWriter/Reader get_matched_publication/subscription...() (2.x) API tests #188

Merged
merged 3 commits into from
Oct 25, 2024
Merged

[21808] Update DataWriter/Reader get_matched_publication/subscription...() (2.x) API tests #188

merged 3 commits into from
Oct 25, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Oct 9, 2024 •
edited
Loading

Description

This PR updates DataWriter/Reader get_matched_publication/subscirption...() tests in the Fast DDS Python 2.x branch as result of API implementation:

IMPORTANT
This PR must be merged after

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Changes are API compatible.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v2.0.1 milestone Oct 9, 2024
@Mario-DL Mario-DL mentioned this pull request Oct 9, 2024
Merged
13 tasks
@Mario-DL
Copy link
Member Author

Mario-DL commented Oct 9, 2024 •
edited
Loading

IMO this PR should target a new minor attached to Fast DDS 3.2.x

@Mario-DL Mario-DL requested review from richiware and removed request for richiware October 17, 2024 16:49
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 17, 2024
@Mario-DL
Refs #21808: Apply second rev
7dd6e8d 
Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL merged commit ecc860d into main Oct 25, 2024
6 checks passed
@Mario-DL Mario-DL deleted the feature/21808 branch October 25, 2024 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richiware richiware richiware approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v2.0.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @richiware