Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fast DDS Spy tool tests #21

Merged
merged 63 commits into from
Jun 22, 2023
Merged

Fast DDS Spy tool tests #21

merged 63 commits into from
Jun 22, 2023

Conversation

irenebm
Copy link
Member

@irenebm irenebm commented Mar 27, 2023 •
edited
Loading

No description provided.

@irenebm irenebm temporarily deployed to codecov March 27, 2023 06:41 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 27, 2023 06:45 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 27, 2023 07:11 — with GitHub Actions Inactive
jparisu
jparisu suggested changes Mar 27, 2023
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These tests must be rechecked, as they do not apport value as they are.
The main problem is that a test from another application that checks closure has been copied.
These tests are meant to test the application, while the one copied only checks closure (and it closes differently than this one).
Tests must be redesign.

fastddsspy_tool/test/application/CMakeLists.txt Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/CMakeLists.txt Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/CMakeLists.txt Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/tests.py Outdated Show resolved Hide resolved
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:01 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:22 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:48 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 06:56 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 07:25 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 28, 2023 14:25 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 10:22 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 11:53 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 29, 2023 13:55 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 05:55 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 08:02 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 09:23 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 30, 2023 15:18 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 31, 2023 09:50 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov March 31, 2023 11:45 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov April 4, 2023 15:12 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov April 5, 2023 06:11 — with GitHub Actions Inactive
@irenebm irenebm mentioned this pull request Apr 11, 2023
Closed
@irenebm
Give more time to stop
1b237bf 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
change kill publisher
0cf9a3d 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
kill publisher
938f640 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Apply changes
f4239f7 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Testing
a8ebe77 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Add docu code
f50431f 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Debug
c05f028 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Apply changes
bc1849e 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm temporarily deployed to codecov June 21, 2023 07:21 — with GitHub Actions Inactive
jparisu
jparisu reviewed Jun 21, 2023
View reviewed changes
fastddsspy_tool/test/application/CMakeLists.txt Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/CMakeLists.txt Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/test.py Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/test_class.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_class.py Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/test_class.py Outdated Show resolved Hide resolved
fastddsspy_tool/test/application/test_class.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_class.py Show resolved Hide resolved
fastddsspy_tool/test/application/one_shot__config.py Outdated Show resolved Hide resolved
@irenebm irenebm temporarily deployed to codecov June 21, 2023 11:18 — with GitHub Actions Inactive
jparisu
jparisu suggested changes Jun 21, 2023
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments about the test cases:

Summarizing: tests are fine, but the range of scenarios that are proven is very thick. I would add comments in README regarding the those scenarios that would be fine to test in the future (any datareader, more than one entity of some kind, etc.)

fastddsspy_tool/test/application/test_cases/one_shot__config_fail_empty_arg.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_cases/one_shot__help.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_cases/one_shot__version.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_cases/one_shot_datareader_verbose_dds.py Show resolved Hide resolved
fastddsspy_tool/test/application/test_cases/one_shot_topics_name_dds.py Outdated Show resolved Hide resolved
@irenebm irenebm temporarily deployed to codecov June 21, 2023 12:10 — with GitHub Actions Inactive
@irenebm
Apply changes
d5fc618 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm temporarily deployed to codecov June 21, 2023 14:09 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov June 21, 2023 14:51 — with GitHub Actions Inactive
@irenebm irenebm temporarily deployed to codecov June 21, 2023 14:55 — with GitHub Actions Inactive
@irenebm
Apply changes
701426c 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm temporarily deployed to codecov June 22, 2023 04:48 — with GitHub Actions Inactive
jparisu
jparisu approved these changes Jun 22, 2023
View reviewed changes
Copy link
Contributor

@jparisu jparisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jparisu jparisu merged commit ce3ae97 into main Jun 22, 2023
@jparisu jparisu deleted the test/tool branch June 22, 2023 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jparisu jparisu jparisu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@irenebm @jparisu