Refs #21710: Empty APIs in RTPSParticipant, RTPSWriter, RTPSReader

Signed-off-by: Mario Dominguez <[email protected]>
eProsima · Sep 25, 2024 · 37e9345 · 37e9345
1 parent bfdb23e
commit 37e9345
Show file tree

Hide file tree

Showing 7 changed files with 82 additions and 0 deletions.
diff --git a/include/fastdds/rtps/participant/RTPSParticipant.h b/include/fastdds/rtps/participant/RTPSParticipant.h
@@ -54,6 +54,8 @@ namespace dds {
 namespace builtin {
 
 class TypeLookupManager;
+struct PublicationBuiltinTopicData;
+struct SubscriptionBuiltinTopicData;
 
 } // namespace builtin
 } // namespace dds
@@ -306,6 +308,30 @@ class RTPS_DllAPI RTPSParticipant
      */
     std::vector<fastdds::rtps::TransportNetmaskFilterInfo> get_netmask_filter_info() const;
 
+    /**
+     * @brief Fills the provided PublicationBuiltinTopicData with the information of the
+     * writer identified by writer_guid.
+     *
+     * @param[in] writer_guid GUID of the writer to get the information from.
+     * @param[out] data PublicationBuiltinTopicData to fill.
+     * @return True if the writer was found and the data was filled.
+     */
+    bool get_publication_info(
+            const GUID_t& writer_guid,
+            fastdds::dds::builtin::PublicationBuiltinTopicData& data) const;
+
+    /**
+     * @brief Fills the provided SubscriptionBuiltinTopicData with the information of the
+     * reader identified by reader_guid.
+     *
+     * @param[in] reader_guid GUID of the reader to get the information from.
+     * @param[out] data SubscriptionBuiltinTopicData to fill.
+     * @return True if the reader was found and the data was filled.
+     */
+    bool get_subscription_info(
+            const GUID_t& reader_guid,
+            fastdds::dds::builtin::SubscriptionBuiltinTopicData& data) const;
+
 #if HAVE_SECURITY
 
     /**

diff --git a/include/fastdds/rtps/reader/RTPSReader.h b/include/fastdds/rtps/reader/RTPSReader.h
@@ -276,6 +276,15 @@ class RTPSReader
         data_filter_ = filter;
     }
 
+    /**
+     * @brief Fills the provided vector with the GUIDs of the matched writers.
+     *
+     * @param[out] guids Vector to be filled with the GUIDs of the matched writers.
+     * @return True if the operation was successful.
+     */
+    RTPS_DllAPI bool get_matched_guids(
+            std::vector<GUID_t>& guids) const;
+
     /*!
      * @brief Returns there is a clean state with all Writers.
      * It occurs when the Reader received all samples sent by Writers. In other words,

diff --git a/include/fastdds/rtps/writer/RTPSWriter.h b/include/fastdds/rtps/writer/RTPSWriter.h
@@ -317,6 +317,15 @@ class RTPSWriter
         return false;
     }
 
+    /**
+     * @brief Fills the provided vector with the GUIDs of the matched readers.
+     *
+     * @param[out] guids Vector to be filled with the GUIDs of the matched readers.
+     * @return True if the operation was successful.
+     */
+    RTPS_DllAPI bool get_matched_guids(
+            std::vector<GUID_t>& guids) const;
+
     /**
      * Tries to remove a change waiting a maximum of the provided microseconds.
      * @param max_blocking_time_point Maximum time to wait for.

diff --git a/src/cpp/rtps/participant/RTPSParticipant.cpp b/src/cpp/rtps/participant/RTPSParticipant.cpp
@@ -201,6 +201,20 @@ std::vector<fastdds::rtps::TransportNetmaskFilterInfo> RTPSParticipant::get_netm
     return mp_impl->get_netmask_filter_info();
 }
 
+bool RTPSParticipant::get_publication_info(
+        const GUID_t&,
+        fastdds::dds::builtin::PublicationBuiltinTopicData&) const
+{
+    return false;
+}
+
+bool RTPSParticipant::get_subscription_info(
+        const GUID_t&,
+        fastdds::dds::builtin::SubscriptionBuiltinTopicData&) const
+{
+    return false;
+}
+
 #if HAVE_SECURITY
 
 bool RTPSParticipant::is_security_enabled_for_writer(

diff --git a/src/cpp/rtps/reader/RTPSReader.cpp b/src/cpp/rtps/reader/RTPSReader.cpp
@@ -435,6 +435,12 @@ bool RTPSReader::is_sample_valid(
     return true;
 }
 
+bool RTPSReader::get_matched_guids(
+        std::vector<GUID_t>&) const
+{
+    return false;
+}
+
 #ifdef FASTDDS_STATISTICS
 
 bool RTPSReader::add_statistics_listener(

diff --git a/src/cpp/rtps/writer/RTPSWriter.cpp b/src/cpp/rtps/writer/RTPSWriter.cpp
@@ -462,6 +462,12 @@ bool RTPSWriter::send_nts(
                    locator_selector.locator_selector.end(), max_blocking_time_point);
 }
 
+bool RTPSWriter::get_matched_guids(
+        std::vector<GUID_t>&) const
+{
+    return false;
+}
+
 #ifdef FASTDDS_STATISTICS
 
 bool RTPSWriter::add_statistics_listener(

diff --git a/test/mock/rtps/RTPSParticipant/fastdds/rtps/participant/RTPSParticipant.h b/test/mock/rtps/RTPSParticipant/fastdds/rtps/participant/RTPSParticipant.h
@@ -49,6 +49,8 @@ namespace dds {
 namespace builtin {
 
 class TypeLookupManager;
+struct PublicationBuiltinTopicData;
+struct SubscriptionBuiltinTopicData;
 
 } // namespace builtin
 } // namespace dds
@@ -225,6 +227,16 @@ class RTPS_DllAPI RTPSParticipant
         return {};
     }
 
+    MOCK_METHOD2(
+        get_publication_info, bool(
+            const GUID_t& writer_guid,
+            fastdds::dds::builtin::PublicationBuiltinTopicData& data));
+
+    MOCK_METHOD2(
+        get_subscription_info, bool(
+            const GUID_t& writer_guid,
+            fastdds::dds::builtin::SubscriptionBuiltinTopicData& data));
+
     const RTPSParticipantAttributes& getRTPSParticipantAttributes()
     {
         return attributes_;